Changes between Version 1 and Version 2 of Ticket #39157, comment 23
- Timestamp:
- 01/05/2017 06:57:13 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #39157, comment 23
v1 v2 2 2 > Looking at [attachment:39157.4.patch], I am not sure why the extra conditionals, `is_home_feed()` and `is_custom_feed()` are being introduced in this patch. I think new conditionals are best left to #20899. 3 3 4 See this comment: https://core.trac.wordpress.org/ticket/20899#comment:195 6 4 In 4.7 we killed all feeds that should not be rendered and missed the case for 'home feed on any site with zero posts' and for 'custom feeds' that don't rely on WP_Query. This is an attempt to bring those feeds back and fix the regression. Normally, I wouldn't be introducing new methods to WP_Query in a point release, but in this case, I think it's the right path forward and has the side effect of solving other problems moving forward.