WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#3917 closed defect (bug) (fixed)

Change wp-login.php to allow web single sign on tools to work

Reported by: anhill Owned by:
Milestone: 2.2 Priority: low
Severity: normal Version: 2.1.2
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Due to a limitation in JavaScript, web single sign-on tools (in this case Novell Access Manager) are unable to do a form-fill SSO authentication to WordPress. The reason is that several of the form elements are named and ID'd "submit". JavaScript gets confused, and won't execute the form fill code, which includes a "document.forms[0].submit()" function to enable the transparent login.

This patch is very simple - it changes name="submit" to name="wp-submit" and id="submit" to id="wp-submit" in wp-login.php.

Hopefully I made the problem clear - feel free to let me know if there are any questions!

Attachments (1)

submit.diff (1.6 KB) - added by anhill 8 years ago.
Patch to wp-login.php changing submit attributes

Download all attachments as: .zip

Change History (8)

@anhill8 years ago

Patch to wp-login.php changing submit attributes

comment:1 @anhill8 years ago

  • Milestone changed from 2.3 to 2.2

comment:2 @westi8 years ago

  • Component changed from Security to Administration
  • Keywords has-patch added
  • Summary changed from wp-login.php change to allow web SSO tools to work to Change wp-login.php to allow web single sign on tools to work

Patch looks good.

Should we give them all unique names instead though?

comment:3 @anhill8 years ago

I think the ones named submit are the only ones that would ever cause a problem - the rest should be fine.

comment:4 @foolswisdom8 years ago

anhill, I think westi is asking if each of those three entries you include in your patch should be given unique names?

comment:5 @JeremyVisser8 years ago

No, because they're the same buttons in separate forms.

comment:6 @rob1n8 years ago

I'm with Jeremy on this one.

comment:7 @ryan8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4981]) Change wp-login submit names and ids. Props anhill. fixes #3917

Note: See TracTickets for help on using tickets.