WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 4 years ago

#39176 closed enhancement (fixed)

Merge two similar "terms" strings in the REST API

Reported by: ramiy's profile ramiy Owned by: rachelbaker's profile rachelbaker
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords: has-patch commit
Focuses: rest-api Cc:

Description

See the attached patch.

Attachments (3)

39176.png​ (12.2 KB) - added by ramiy 9 years ago.
39176.patch​ (1019 bytes) - added by ramiy 9 years ago.
39176.2.patch​ (2.1 KB) - added by ramiy 9 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
9 years ago

@ramiy
9 years ago

#1 @swissspidy
9 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 4.8

#2 follow-up: @ocean90
9 years ago

  • Component changed from REST API to Taxonomy
  • Type changed from defect (bug) to enhancement

Should we also change Term doesn't exist. to Term does not exist. for consistency, see #38913?

@ramiy
9 years ago

#3 in reply to: ↑ 2 @ramiy
9 years ago

Replying to ocean90:

Should we also change Term doesn't exist. to Term does not exist. for consistency, see #38913?

Done in the second patch.

#4 @rachelbaker
9 years ago

  • Owner set to rachelbaker
  • Resolution set to fixed
  • Status changed from new to closed

In 39648:

REST API: Merge similiar error message strings in the Terms Controller.

Replaces the "doesn't" contraction with "does not" to be consistent with similar strings in WP_Error messages when a specified term or parent term is missing in WP_REST_Terms_Controller.

Props ramiy, ocean90.
Fixes #39176.

#5 @audrasjb
4 years ago

In 52978:

Administration: Replace contracted verb forms for better consistency.

This changeset replaces contracted verb forms like doesn't, can't, or isn't with non-contracted forms like does not, cannot, or is not, for better consistency across the WordPress administration. It also updates some corresponding unit tests strings.

Props Presskopp, socalchristina, aandrewdixon, francina, SergeyBiryukov, JeffPaul, audrasjb, hellofromTonya.
Fixes #38913.
See #39176.

Note: See TracTickets for help on using tickets.