Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#39178 closed enhancement (fixed)

REST API: Improve strings added after 4.7 string freeze

Reported by: jnylen0's profile jnylen0 Owned by: adamsilverstein's profile adamsilverstein
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.7
Component: REST API Keywords: has-patch commit
Focuses: Cc:


We fixed a few API bugs in 4.7 that required new error strings. Some of these were during string freeze, so we repurposed existing strings rather than adding new ones.

We should go through and update these to better messages and error codes. For example, [39440] added rest_orderby_include_missing_include which needs a more helpful message and a less verbose error code (see the rest_no_search_term_defined error immediately above).

Attachments (2)

39178.diff (926 bytes) - added by PranaliPatel 6 years ago.
Update the error string messages.
39178.2.diff (999 bytes) - added by adamsilverstein 6 years ago.

Download all attachments as: .zip

Change History (15)

#1 @ocean90
6 years ago

Note that we usually don't change strings in minor releases.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.

6 years ago

#3 @jbpaul17
6 years ago

  • Milestone changed from 4.7.1 to 4.8

Given that this is more of a "nice to have" and not a breaking issue, we're going to plan on resolving this in 4.8. See linked Slack discussion for conversation during/after today's bug scrub.

6 years ago

Update the error string messages.

#4 @PranaliPatel
6 years ago

  • Keywords has-patch added; needs-patch removed

#5 @jbpaul17
6 years ago

  • Keywords needs-testing added

This needs testing and an owner if its going to land in 4.8. Anyone care to help review this to see it land in 4.8?

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.

6 years ago

#7 @jbpaul17
6 years ago

  • Owner set to adamsilverstein
  • Status changed from new to assigned

#8 @adamsilverstein
6 years ago

I will test and commit what we have so far, are there any other strings we need to adjust @jnylen0?

#9 @adamsilverstein
6 years ago

39178.2.diff - slight language fix define a include changed to define an include

#10 @adamsilverstein
6 years ago

  • Keywords commit added; needs-testing removed

#11 @adamsilverstein
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 40571:

REST API: Improve strings added after 4.7 string freeze.

Clarify the rest_orderby_include_missing_include error message.

Props PranaliPatel.
Fixes #39178.

#12 @jnylen0
6 years ago

In 40606:

REST API: Improve a few more strings added after the 4.7 string freeze.

See #39178.

See also #40720 for potential follow-up steps.

#13 @jnylen0
6 years ago

In 40630:

REST API: Update wp-api.js fixtures after string changes.

See #39178.

Note: See TracTickets for help on using tickets.