REST API: Improve strings added after 4.7 string freeze

[jnylen0]

We fixed a few API bugs in 4.7 that required new error strings. Some of these were during string freeze, so we repurposed existing strings rather than adding new ones.

We should go through and update these to better messages and error codes. For example, [39440] added rest_orderby_include_missing_include which needs a more helpful message and a less verbose error code (see the rest_no_search_term_defined error immediately above).

[ocean90]

Note that we usually don't change strings in minor releases.

[jbpaul17]

Given that this is more of a "nice to have" and not a breaking issue, we're going to plan on resolving this in 4.8. See linked Slack discussion for conversation during/after today's bug scrub.

[PranaliPatel]

Update the error string messages.

[jbpaul17]

This needs testing and an owner if its going to land in 4.8. Anyone care to help review this to see it land in 4.8?

[adamsilverstein]

I will test and commit what we have so far, are there any other strings we need to adjust @jnylen0?

[adamsilverstein]

39178.2.diff​ - slight language fix define a include changed to define an include

[adamsilverstein]

In 40571:

REST API: Improve strings added after 4.7 string freeze.

Clarify the rest_orderby_include_missing_include error message.

Props PranaliPatel.
Fixes #39178.

[jnylen0]

In 40606:

REST API: Improve a few more strings added after the 4.7 string freeze.

See #39178.

See also #40720 for potential follow-up steps.

[jnylen0]

In 40630:

REST API: Update wp-api.js fixtures after string changes.

See #39178.