Replace `is_super_admin()` check with current_user_can( 'manage_network_options' ) in wp-admin/options.php

[sathyapulse]

This is part of the #37616 task. There are 2 is_super_admin() checks in wp-includes/option.php that should be replaced with current_user_can( 'manage_network' ).

See: https://core.trac.wordpress.org/ticket/37616#comment:26

[flixos90]

Hi @sathyapulse, and thanks for the patch! It looks good so far. One minor thing we could adjust is to add curly braces around the clause in line 163: Since we are changing the line anyway, it's a good habit to adjust this clause to follow the proper coding standards.

Feel free to update your patch accordingly, that would be great! :)

[sathyapulse]

Hi @flixos90,

Thank you for the suggestion. I should have noticed that earlier. I have attached the new patch file which includes the missing curly braces throughout the file. Please let me know if any other changes need to be done in the file. I am happy to do it.

[flixos90]

Thanks for the update @sathyapulse.

I think we had a small misunderstanding here, the code format should only be adjusted in lines (or their direct environment) which are changed anyway. In 39200.1.patch​ you added curly braces throughout the entire file, but this makes the diff unreadable since it's unclear what the actual functional code change was.
Only the one clause that you changed in 39200.patch​ line 163 should get curly braces, please ignore the other ones. Could you please update the patch? It's probably easiest if you do it based on your initial patch.

[sathyapulse]

Sorry, the patch is updated as per your request.

[flixos90]

Perfect, thanks a lot @sathyapulse!

[flixos90]

In 39933:

Multisite: Replace is_super_admin() with manage_network_options in wp-admin/options.php.

Props sathyapulse.
Fixes #39200. See #37616.