![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 10 years ago
Closed 9 years ago
#39204 closed enhancement (fixed)
Replace `is_super_admin()` check with `manage_network_users` cap check in wp-admin/users.php
| Reported by: | abhishek kaushik | Owned by: | flixos90 |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.8 |
| Component: | Role/Capability | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | multisite |
Description (last modified by )
This is part of the #37616 task. There is 1 is_super_admin() check in wp-admin/users.php that should be replaced with current_user_can( 'manage_network_users' ).
See https://core.trac.wordpress.org/ticket/37616#comment:28
Attachments (2)
Change History (6)
#1
@
10 years ago
- Description modified (diff)
- Focuses administration removed
- Keywords has-patch needs-refresh added
- Milestone Awaiting Review → 4.8
- Owner set to
- Status new → reviewing
- Summary Replace `is_super_admin()` checks with `manage_network` cap checks in wp-admin/users.php → Replace `is_super_admin()` check with `manage_network_users` cap check in wp-admin/users.php
- Type defect (bug) → enhancement
- Version trunk
Hi @abhishek kaushik, and thanks for the patch! It generally looks good, it just does a little too much. Only the first occurrence of is_super_admin() (in line 125) should be replaced here, the other two are already handled in #39063. Would you mind updating your patch accordingly? :)
Note:
See TracTickets
for help on using tickets.
Replaced is_super_admin() with current_user_can( 'manage_network' )