Opened 8 years ago
Closed 8 years ago
#39204 closed enhancement (fixed)
Replace `is_super_admin()` check with `manage_network_users` cap check in wp-admin/users.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Role/Capability | Keywords: | has-patch |
Focuses: | multisite | Cc: |
Description (last modified by )
This is part of the #37616 task. There is 1 is_super_admin() check in wp-admin/users.php that should be replaced with current_user_can( 'manage_network_users' )
.
See https://core.trac.wordpress.org/ticket/37616#comment:28
Attachments (2)
Change History (6)
#1
@
8 years ago
- Description modified (diff)
- Focuses administration removed
- Keywords has-patch needs-refresh added
- Milestone changed from Awaiting Review to 4.8
- Owner set to flixos90
- Status changed from new to reviewing
- Summary changed from Replace `is_super_admin()` checks with `manage_network` cap checks in wp-admin/users.php to Replace `is_super_admin()` check with `manage_network_users` cap check in wp-admin/users.php
- Type changed from defect (bug) to enhancement
- Version trunk deleted
Hi @abhishek kaushik, and thanks for the patch! It generally looks good, it just does a little too much. Only the first occurrence of is_super_admin()
(in line 125) should be replaced here, the other two are already handled in #39063. Would you mind updating your patch accordingly? :)
Note: See
TracTickets for help on using
tickets.
Replaced is_super_admin() with current_user_can( 'manage_network' )