WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39204


Ignore:
Timestamp:
12/09/2016 04:22:09 PM (8 years ago)
Author:
flixos90
Comment:

Hi @abhishek kaushik, and thanks for the patch! It generally looks good, it just does a little too much. Only the first occurrence of is_super_admin() (in line 125) should be replaced here, the other two are already handled in #39063. Would you mind updating your patch accordingly? :)

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #39204

    • Property Status changed from new to reviewing
    • Property Focuses administration removed
    • Property Summary changed from Replace `is_super_admin()` checks with `manage_network` cap checks in wp-admin/users.php to Replace `is_super_admin()` check with `manage_network_users` cap check in wp-admin/users.php
    • Property Keywords has-patch needs-refresh added
    • Property Version changed from trunk to
    • Property Milestone changed from Awaiting Review to 4.8
    • Property Owner set to flixos90
    • Property Type changed from defect (bug) to enhancement

  • Ticket #39204 – Description

    initial v1  
    1 This is part of the #37616 task. There are 3 is_super_admin() checks in wp-admin/users.php that should be replaced with current_user_can( 'manage_network' ).
     1This is part of the #37616 task. There is 1 is_super_admin() check in wp-admin/users.php that should be replaced with `current_user_can( 'manage_network_users' )`.
    22See https://core.trac.wordpress.org/ticket/37616#comment:28