Replace is_super_admin() check with current_user_can( 'manage_options' ) in wp-admin/options-general.php

[Dhaval Parekh]

This is part of the https://core.trac.wordpress.org/ticket/37616#comment:28 task. There is 1 is_super_admin() checks in wp-admin/options-general.php that should be replaced with current_user_can( 'manage_options' ).

[Dhaval Parekh]

Replaced is_super_admin() check with current_user_can( 'manage_options' )

[flixos90]

Hi @Dhaval Parekh, and thanks for the patch - looks good!

[johnbillion]

The intention of this line of code is to only show the WPLANG warning to super admins on a multisite installation. A regular administrator on multisite should not see this message, but an administrator on a single site installation should.

I'm not sure which cap would be more appropriate to check for here. Maybe:

if ( ! is_multisite() || current_user_can( 'manage_network_options )`

[ocean90]

I wouldn't mind if we just remove this warning. It was introduced 2 years ago in [29630].

[flixos90]

+1 on removing the warning. I think the regular _deprecated_argument() call can remain, it should really be sufficient as a warning for a developer.

Let's open a new ticket if we agree on this - this here would then become invalid. :)

[flixos90]

39207.diff​ makes the check available to network administrators on multisite and regular administrators on non-multisite.

Generally using a new meta capability would be more elegant, but since it is only about a simple notice that might possibly removed soon, let's use the check from the new patch.

[flixos90]

In 39947:

Multisite: Replace is_super_admin() with a proper capability check when showing a notice about WPLANG.

In multisite, the notice is displayed to users that have the manage_network_options capability. In non-multisite, the notice is displayed to users with the manage_options capability.

Props Dhaval Parekh.
Fixes #39207. See #37616.