Make WordPress Core

Opened 15 months ago

Last modified 3 months ago

#39213 assigned defect (bug)

Audit the network pages notices.

Reported by: afercia Owned by: marksabbath
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.7
Component: Networks and Sites Keywords: has-ui-feedback good-first-bug has-patch needs-testing needs-refresh
Focuses: ui, multisite Cc:

Description (last modified by afercia)

Some notices and messages in the network pages are printed out in simple paragraphs and don't make use of the WordPress notices styling. For example, in my-sites.php:

_e( 'You must be a member of at least one site to use this page.' )

There are probably a few ones across the network screens. For design consistency, they should all use a wrapper <div> element with the proper CSS classes notice, notice-success, notice-error etc. Also, the old CSS classes updated and error should be replaced with the new ones, where applicable.

Attachments (2)

39213.diff (1.2 KB) - added by marksabbath 15 months ago.
39213.1.diff (1.2 KB) - added by marksabbath 8 months ago.

Download all attachments as: .zip

Change History (11)

#1 @afercia
15 months ago

  • Description modified (diff)

#2 @karmatosed
15 months ago

  • Keywords has-ui-feedback added; ui-feedback removed

Good catch, I agree this should have div added for design consistency and the proper class.

15 months ago

#3 @marksabbath
15 months ago

  • Keywords has-patch added
  • Version set to 4.7

Hello, people!

I've researched on this file and found only 2 occurrences:

Line 54 and 71.

Line 71 should be protected by the capabilities, but I've updated it as well. See attached the patch.

#4 @DrewAPicture
8 months ago

  • Owner set to marksabbath
  • Status changed from new to assigned

Assigning ownership to mark the good-first-bug as "claimed".

This ticket was mentioned in Slack in #core-multisite by stevenkword. View the logs.

8 months ago

#6 @stevenkword
8 months ago

  • Keywords needs-testing added

39213.diff still applies cleanly as of July 10, 2017.

Per multisite bug scrub: " @earnjam -- I don’t see any issues with the patch on 39213. Would just want to confirm there weren’t any other notices/messages that needed styling that were missed."

@marksabbath -- This looks largely complete. What tasks do you feel is missing in order to push this over the finish line? I'm adding the keyword, 'needs-user-testing' for now. Do you need any feedback?

Last edited 8 months ago by stevenkword (previous) (diff)

#7 @afercia
8 months ago

  • Keywords needs-refresh added

The elements nesting in the second notice in the patch is not correct:

<p><strong> ... </p></strong>

8 months ago

#8 @marksabbath
8 months ago

You're completely correct @afercia thanks for noticing and reporting that error. It should be fixed in this patch: https://core.trac.wordpress.org/attachment/ticket/39213/39213.1.diff

@stevenkword I think we're good to go. Thank you all for reviewing and sending feedbacks.

#9 @marksabbath
3 months ago

Hey @stevenkword anything that I could be doing to make this update moving forward?

Note: See TracTickets for help on using tickets.