Audit the network pages notices.

[afercia]

Some notices and messages in the network pages are printed out in simple paragraphs and don't make use of the WordPress notices styling. For example, in my-sites.php:

_e( 'You must be a member of at least one site to use this page.' )

There are probably a few ones across the network screens. For design consistency, they should all use a wrapper <div> element with the proper CSS classes notice, notice-success, notice-error etc. Also, the old CSS classes updated and error should be replaced with the new ones, where applicable.

[karmatosed]

Good catch, I agree this should have div added for design consistency and the proper class.

[marksabbath]

Hello, people!

I've researched on this file and found only 2 occurrences:

Line 54 and 71.

Line 71 should be protected by the capabilities, but I've updated it as well. See attached the patch.

[DrewAPicture]

Assigning ownership to mark the good-first-bug as "claimed".

[stevenkword]

39213.diff​ still applies cleanly as of July 10, 2017.

@marksabbath -- This looks largely complete. What tasks do you feel is missing in order to push this over the finish line? I'm adding the keyword, 'needs-user-testing' for now. Do you need any feedback?

[afercia]

The elements nesting in the second notice in the patch is not correct:

<p><strong> ... </p></strong>

[marksabbath]

You're completely correct @afercia thanks for noticing and reporting that error. It should be fixed in this patch: https://core.trac.wordpress.org/attachment/ticket/39213/39213.1.diff

@stevenkword I think we're good to go. Thank you all for reviewing and sending feedbacks.

[marksabbath]

Hey @stevenkword anything that I could be doing to make this update moving forward?

[jeremyfelt]

These changes look good. There's an extra > in the class attribute on the second message, but I'll take care of that in commit.

It takes messing with capabilities to even see the "You must be a member of at least one site to use this page." message as there are two other errors that would more likely show beforehand, but this is now displayed consistent with other error notices.

Thanks @marksabbath!

[jeremyfelt]

It does look like there several other notices that can be updated with notice-error and notice-success in src/wp-admin/network/*.php.

@marksabbath Would you be okay submitting an updated patch covering those as well?

[marksabbath]

Totes @jeremyfelt will work on that.

[aryamaaru]

Please review my patch anybody

[marksabbath]

Hey @jeremyfelt here is the complete patch: https://core.trac.wordpress.org/attachment/ticket/39213/39213.patch. Would you mind taking a look at it and let me know if there's any other thing that we would need to do to move this forward?

Thanks in advance :)

[pento]

Patch needs review.

[davidbaumwald]

I tried applying the most recent patch, and it has some conflicts.

[desrosj]

This one still needs a refresh and thorough review. I'm going to punt to 6.2 as RC 1 is due out early next week.

Trac ticket: https://core.trac.wordpress.org/ticket/39213

[robinwpdeveloper]

I have created a new PR.
Followed this patch https://core.trac.wordpress.org/attachment/ticket/39213/39213.patch.

Few things I did different than the last patch:

• Kept id="message"
• kept inline class as it is neither updated nor notice class
• Made few untouched occurrences as well.

Let me know if I need to do any more changes.

[obayedmamur]

Tested PR: ​https://github.com/WordPress/wordpress-develop/pull/3888.

Searched with class="updated notice in directory src/wp-admin/network/*.php

Before: 18 results in 10 files. [Screenshot ​https://d.pr/i/k2uoPW ]

After: 0 results. [Screenshot ​https://d.pr/i/6OwBA9 ]

Let me know how to test the UI or which pages to test.

[joedolson]

Just added an updated patch based on @robinwpdeveloper's PR. Handles a few additional cases that were missed & uses a variable ID attribute in the one case (user-new.php) where messages can be an array when multiple users are added at once. The first message will still be id="message" but subsequent will be id="message-{$i}".

[joedolson]

Update to PR by robinwpdeveloper

[joedolson]

No space in $i++

Updates classes used to be consistent; prevents duplicate IDs; uses same markup throughout.

Trac ticket: https://core.trac.wordpress.org/ticket/39213

[joedolson]

This looks ready to go to me; lets get it done.

[joedolson]

My one hesitation is that I can't see a way that the add new user message ends up as an array with multiple elements, so I'm feeling like it's unnecessary to construct that array rather than just generating a string. There's no iteration present that would add additional messages to the array, so it's always an array with one element.

Adding an alternate version of this that simplifies this code.

[joedolson]

Alternate version that builds success message for add new user as a string instead of array.

[joedolson]

Avoids re-use of variable name & fixes potentially undeclared variable.

[joedolson]

If there's any super obscure way that those messages can actually be an array, I think it'll only come up in use. But I don't think there is, so let's get this moving, for real this time.

[joedolson]

In 55418:

Networks and Sites: Use consistent markup for admin notices.

Fix admin notices in network screens so they use consistent markup and style.

Props afercia, marksabbath, stevenkword, jeremyfelt, aryamaaru, robinwpdeveloper, obayedmamur, joedolson.
Fixes #39213.

Fixed in https://core.trac.wordpress.org/changeset/55418

Fixed in https://core.trac.wordpress.org/changeset/55418