WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#39214 closed defect (bug) (maybelater)

Twenty Seventeen: Edit shortcut icons getting cut for mobile device preview in customizer

Reported by: umesh.nevase Owned by: davidakennedy
Priority: normal Milestone:
Component: Bundled Theme Version: 4.7
Severity: normal Keywords: has-patch
Cc: Focuses: ui

Description

When checking for device preview mode, the shortcut icons for Header image, Site title and tagline getting cut on left side for mobile preview.

Attachments (2)

edit-shortcut-issue.png​ (181.1 KB ) - added by umesh.nevase 10 years ago.
Screenshot of issue
39214.diff​ (443 bytes ) - added by umesh.nevase 10 years ago.
Patch for issue

Download all attachments as: .zip

Change History (9)

@umesh.nevase
10 years ago

Screenshot of issue

@umesh.nevase
10 years ago

Patch for issue

#1 @umesh.nevase
10 years ago

  • Keywords has-patch added

#2 @umesh.nevase
10 years ago

If we increase padding of wrap class by 0.1 em, the issue will get fixed. It will not affect on any other css. The padding for wrap class get overridden to 3em in further css.

This ticket was mentioned in ​Slack in #core-customize by celloexpressions. ​View the logs.
10 years ago

#4 @celloexpressions
10 years ago

  • Component Customize → Bundled Theme
  • Summary Edit shortcut icons getting cut for mobile device preview in customizer → Twenty Seventeen: Edit shortcut icons getting cut for mobile device preview in customizer

Moving for the bundled theme component to consider since this is specific to Twenty Seventeen cc @davidakennedy. I think it's probably okay to be slightly cut off, though.

#5 @afercia
10 years ago

  • Focuses accessibility removed

Not strictly related to accessibility, removing the focus.

#6 @westonruter
10 years ago

  • Owner set to davidakennedy
  • Status new → assigned

#7 @davidakennedy
10 years ago

  • Milestone Awaiting Review
  • Resolution → maybelater
  • Status assigned → closed

Thanks for the report @umesh.nevase!

While the appearance here isn't ideal, I'm inclined to leave it since the buttons are still operable and the cut-off part is very slight and only happens on smaller screens.

However, if more users report this or issues around it, we can reexamine.

Note: See TracTickets for help on using tickets.