Remove 1 `is_super_admin()` check in wp-admin/user-new.php

[supercoder]

This is part of the #37616 task. when adding a network administrator who's already on the site, that user is still invited again

[flixos90]

Hi @supercoder, and thanks for the ticket and patch! :)

Can you maybe have another look at the patch and review "Ticket 11" on https://core.trac.wordpress.org/ticket/37616#comment:26 in detail? In your patch you removed the $username != null check, but instead the !is_super_admin( $user_id ) check should be removed. You could also adjust the spacing in ( array_key_exists($blog_id, get_blogs_of_user($user_id)) ) (same line) to follow the WordPress coding standards.

[supercoder]

Replying to flixos90:

Hi @supercoder, and thanks for the ticket and patch! :)

Can you maybe have another look at the patch and review "Ticket 11" on https://core.trac.wordpress.org/ticket/37616#comment:26 in detail? In your patch you removed the $username != null check, but instead the !is_super_admin( $user_id ) check should be removed. You could also adjust the spacing in ( array_key_exists($blog_id, get_blogs_of_user($user_id)) ) (same line) to follow the WordPress coding standards.

Thanks for the update. I have updated the patch. Please check.

[flixos90]

Thanks @supercoder, looks good now!

[flixos90]

In 39946:

Multisite: Remove unnecessary is_super_admin() check when adding an existing user to a site.

Prior to this change, a super admin user that is added to a site who they are already a member of would still get reinvited.

Props supercoder.
Fixes #39220. See #37616.