Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#39229 closed defect (bug) (invalid)

Notification for changesets

Reported by: pavelevap Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords:
Focuses: Cc:


When I want to leave Customizer (after making some changes which I do not want to save), there is only browser warning window that I can loose changes. It is not actually true, because they are saved as changeset, but users do not know about it.

Warning should be changed to something explaining this feature to users like "You can copy URL with current changes"...

Change History (3)

#1 @westonruter
5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

You're right, the dialog displayed is not entirely true. However, the are-you-sure dialog (AYS) is being displayed for the very reason you mention and that is “users do not know about it”. In 4.7 there is no UI for regaining access to a given changeset, so the warning is displayed to prevent the user from losing access to their changes. The more fundamental problem for this dialog is that it is provided by the browser and we have no control over it, other than to ask the browser to warn the user. We cannot change the text of the dialog.

The Customize Snapshots plugin (important: not yet compatible with 4.7) is prototyping the UI for explicitly creating a persistent Draft of a changeset and it also provides an edit posts admin screen that lists out all these drafted changesets. In this plugin, once a Draft is made the AYS dialog does not appear. For more on this in core, you can follow #31089.

#2 follow-up: @pavelevap
5 years ago

Thank you for explanation! I know about this plugin, but I wanted to promote changeset feature a little bit for current users. Maybe some kind of inline message in preview window would be helpful, but it will have to probably wait for #35210. Nobody knows about this changeset feature (and how it really works) and some warnings are also misleading...

#3 in reply to: ↑ 2 @westonruter
5 years ago

Replying to pavelevap:

Nobody knows about this changeset feature (and how it really works) and some warnings are also misleading...

The feature is pretty exhaustively documented in https://make.wordpress.org/core/2016/10/12/customize-changesets-technical-design-decisions/

Yeah, and the warning is presented by the browser and we cannot customize it.

Note: See TracTickets for help on using tickets.