![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 10 years ago
Closed 10 years ago
#39235 closed defect (bug) (fixed)
incorect @covers parm in unit test causes php covers report to fail
| Reported by: | pbearne | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.8 |
| Component: | Build/Test Tools | Version: | 4.8 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
Just comment text fix
Please do add so we can run the covers reports
Attachments (2)
Change History (9)
#2
@
10 years ago
Found some more incorrect @coverage parms
Also removed leading whitespace from themeFile.php as this causing the cover report to fail
#3
follow-up:
↓ 4
@
10 years ago
- Keywords dev-feedback has-unit-tests removed
- Milestone Awaiting Review → 4.8
Thanks for the patch and help testing this @pbearne
I've attached patch coverage_prams.patch to https://github.com/aaronjorbin/wordpress.codecov/pull/1
The associated Travis CI job: https://travis-ci.org/aaronjorbin/wordpress.codecov/builds/183473507
#4
in reply to: ↑ 3
@
10 years ago
The Travis CI job failed:
https://travis-ci.org/aaronjorbin/wordpress.codecov/builds/183473507#L1125
The job exceeded the maximum time limit for jobs, and has been terminated.
Edit: I closed and reopened the PR to trigger a new Travis CI job, this should determine if the above failure was a once of isolated instance or not.
#5
@
10 years ago
The coverage reports seem to very slow I am not sure how we can sort this unless we have full control of the box and can provide more resources
#6
@
10 years ago
I've updated the pull request to utilise Travis CI Ubuntu Trusty and Google Compute Engine (~2xRAM/Similar CPU)
https://github.com/aaronjorbin/wordpress.codecov/pull/2
https://travis-ci.org/aaronjorbin/wordpress.codecov/builds/183806410
found some more