WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#39235 closed defect (bug) (fixed)

incorect @covers parm in unit test causes php covers report to fail

Reported by: pbearne Owned by: SergeyBiryukov
Milestone: 4.8 Priority: normal
Severity: normal Version: trunk
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

Just comment text fix

Please do add so we can run the covers reports

https://phpunit.de/manual/current/en/textui.html

Attachments (2)

adminbar.php.patch (425 bytes) - added by pbearne 3 months ago.
coverage_prams.patch (1.7 KB) - added by pbearne 3 months ago.
found some more

Download all attachments as: .zip

Change History (9)

#1 @pbearne
3 months ago

  • Keywords has-patch dev-feedback has-unit-tests added

@pbearne
3 months ago

found some more

#2 @pbearne
3 months ago

Found some more incorrect @coverage parms
Also removed leading whitespace from themeFile.php as this causing the cover report to fail

Last edited 3 months ago by pbearne (previous) (diff)

#3 follow-up: @netweb
3 months ago

  • Keywords dev-feedback has-unit-tests removed
  • Milestone changed from Awaiting Review to 4.8

Thanks for the patch and help testing this @pbearne

I've attached patch coverage_prams.patch to https://github.com/aaronjorbin/wordpress.codecov/pull/1

The associated Travis CI job: https://travis-ci.org/aaronjorbin/wordpress.codecov/builds/183473507

#4 in reply to: ↑ 3 @netweb
3 months ago

The Travis CI job failed:

https://travis-ci.org/aaronjorbin/wordpress.codecov/builds/183473507#L1125
The job exceeded the maximum time limit for jobs, and has been terminated.

Edit: I closed and reopened the PR to trigger a new Travis CI job, this should determine if the above failure was a once of isolated instance or not.

Last edited 3 months ago by netweb (previous) (diff)

#5 @pbearne
3 months ago

The coverage reports seem to very slow I am not sure how we can sort this unless we have full control of the box and can provide more resources

#6 @netweb
3 months ago

I've updated the pull request to utilise Travis CI Ubuntu Trusty and Google Compute Engine (~2xRAM/Similar CPU)

https://github.com/aaronjorbin/wordpress.codecov/pull/2

https://travis-ci.org/aaronjorbin/wordpress.codecov/builds/183806410

#7 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 39918:

Build/Test Tools: Correctly reference function names in @covers entries.

Props pbearne.
Fixes #39235.

Note: See TracTickets for help on using tickets.