Opened 8 years ago
Closed 8 years ago
#39235 closed defect (bug) (fixed)
incorect @covers parm in unit test causes php covers report to fail
Reported by: | pbearne | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | 4.8 |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | Cc: |
Description
Just comment text fix
Please do add so we can run the covers reports
Attachments (2)
Change History (9)
#2
@
8 years ago
Found some more incorrect @coverage parms
Also remove leading whitespace from file as this causing the cover report to fail
#3
follow-up:
↓ 4
@
8 years ago
- Keywords dev-feedback has-unit-tests removed
- Milestone changed from Awaiting Review to 4.8
Thanks for the patch and help testing this @pbearne
I've attached patch coverage_prams.patch to https://github.com/aaronjorbin/wordpress.codecov/pull/1
The associated Travis CI job: https://travis-ci.org/aaronjorbin/wordpress.codecov/builds/183473507
#4
in reply to:
↑ 3
@
8 years ago
The Travis CI job failed:
https://travis-ci.org/aaronjorbin/wordpress.codecov/builds/183473507#L1125
The job exceeded the maximum time limit for jobs, and has been terminated.
Edit: I closed and reopened the PR to trigger a new Travis CI job, this should determine if the above failure was a once of isolated instance or not.
#5
@
8 years ago
The coverage reports seem to very slow I am not sure how we can sort this unless we have full control of the box and can provide more resources
#6
@
8 years ago
I've updated the pull request to utilise Travis CI Ubuntu Trusty and Google Compute Engine (~2xRAM/Similar CPU)
https://github.com/aaronjorbin/wordpress.codecov/pull/2
https://travis-ci.org/aaronjorbin/wordpress.codecov/builds/183806410
found some more