WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#39238 accepted defect (bug)

The active handler for a video header isn't accessible

Reported by: bradyvercher Owned by: joemcgill
Milestone: Future Release Priority: normal
Severity: normal Version: 4.7
Component: Themes Keywords: has-patch
Focuses: Cc:
PR Number:

Description

In wp-custom-header.js, the handler used for displaying the video should be assigned to wp.customHeader.activeHandler for other scripts to access. However, with the way it's currently being assigned, that property is always undefined.

For reference, this is where the assignment currently happens.

Attachments (1)

39238.diff (639 bytes) - added by bradyvercher 3 years ago.

Download all attachments as: .zip

Change History (6)

@bradyvercher
3 years ago

#1 @bradyvercher
3 years ago

  • Keywords has-patch added

39238.diff assigns the handler to the activeHandler properly immediately before calling the handler's initialize() method to ensure the property always has the correct value.

#2 @joemcgill
3 years ago

  • Milestone changed from Awaiting Review to 4.8
  • Owner set to joemcgill
  • Status changed from new to accepted

This ticket was mentioned in Slack in #core by flixos90. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by obenland. View the logs.


2 years ago

#5 @obenland
2 years ago

  • Milestone changed from 4.8 to Future Release
Note: See TracTickets for help on using tickets.