#39246 closed defect (bug) (fixed)
Theme deletion has a JS error that prevents multiple themes from being deleted.
Reported by: | Hristo Sg | Owned by: | obenland |
---|---|---|---|
Milestone: | 4.7.1 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | Themes | Keywords: | |
Focuses: | javascript | Cc: |
Description (last modified by )
In order to recreate the problem:
- install multiple themes
- delete a theme and close the window
- try deleting a second one - it fails
on the first deletion, I see a JS error in the console:
Error: Syntax error, unrecognized expression: [data-slug="twentyfifteen"
In the wp-admin/js/theme.js there is a line:
$( '[data-slug="' + response.slug + '"' ).css( { backgroundColor:'#faafaa' } ).fadeOut( 350, function() {
in which I believe the shortcode is not closed and should be
$( '[data-slug="' + response.slug + '"]' ).css( { backgroundColor:'#faafaa' } ).fadeOut( 350, function() {
I was testing on Safari Version 10.0.1 (12602.2.14.0.7)
Change History (8)
#2
@
8 years ago
- Description modified (diff)
- Focuses javascript added
- Owner set to obenland
- Status changed from new to accepted
#3
in reply to:
↑ 1
@
8 years ago
Replying to dd32:
curious how it was missed - does the post-fadeout callback function correctly after this is fixed?
It works in both Chrome and Firefox, I assume no one then tested it in Safari
Note: See
TracTickets for help on using
tickets.
Shifting to 4.7.1, confirmed that the bracket is missing.
I see no reason not to fix it here, although curious how it was missed - does the post-fadeout callback function correctly after this is fixed?
This was introduced with [37714] so I'm going to call upon @obenland to test.
(Note: A patch for a single character isn't needed, unless other changes are also needed here, if you test, feel free to skip the patch and just comment with your findings)