WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #39261


Ignore:
Timestamp:
02/26/2024 10:38:20 PM (17 months ago)
Author:
sabernhardt
Comment:

The colors were updated in [50025], but I still see a slight variation between the Yoast SEO icon and dashicons in the default color scheme.

We could consider removing the RGBA and assign the hexadecimal color only. [31422] added the RGBA with a fallback for older browsers, and now browsers would rarely use hexadecimal for the dashicons. However, in the unfinished custom properties project, @ryelle's ​branch suggested defining the color with the hex code.

I would rather not try using opacity (of about 0.9) in the default scheme because it would not be appropriate in the other schemes.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #39261

    • Property Keywords has-patch 2nd-opinion added
    • Property Focuses css added
    • Property Component changed from General to Administration

  • Ticket #39261 – Description

    initial v3  
    33I'm currently working with custom SVG icons for my custom post types, but i can see that these icons have a slightly different color than the native dashicons. It seems like the SVG-painter paints my SVG-icons in the wrong base-color.
    44
    5 I'm using the default theme "fresh" and the base is set to "#82878c". If i change to for example "#9EA3A8" my SVG-icons looks more like the native dashicons. Maybe the basecolor is a bit off?
    6 File: wp-includes/general-template.php:3428
     5I'm using the default theme "fresh" and the base is set to `#82878c`. If i change to for example `#9EA3A8` my SVG-icons looks more like the native dashicons. Maybe the basecolor is a bit off?
     6File: [https://core.trac.wordpress.org/browser/branches/4.7/src/wp-includes/general-template.php#L3428 wp-includes/general-template.php:3428]
    77
    88I can also see that this affects the SVG in other plugins (Yoast SEO, WPML etc.).