Changes between Initial Version and Version 1 of Ticket #39265, comment 65
- Timestamp:
- 06/16/2021 11:03:15 PM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #39265, comment 65
initial v1 1 1 In doing a deep and thorough review of PR 1255, it's huge with currently 570 files changed. Tackling one big commit will be too big of an ask of a core committer. To reduce the impact on core committers and thus get the changes committed, @pbearne and I discussed and decided to the following process: 2 2 3 - I'll do the thorough code review of a batch of files from PR 1255 3 - I'll do the thorough code review of a batch of files from PR 1255 which includes reasoning behind any changes 4 4 - If there are changes requested, Paul will update the branch 5 5 - Then one of us will create a "batch patch" … … 7 7 - Once committed, the changes will merged into the PR's branch 8 8 9 Batch-by-batch the PR will get thoroughly reviewed and committed.9 The PR then is the source truth we'll use for tracking what remains. Batch-by-batch the PR will get thoroughly reviewed and committed.