WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#39294 closed defect (bug) (fixed)

Incorrect docs for pre_do_shortcode_tag and do_shortcode_tag filters

Reported by: pento Owned by: dd32
Milestone: 4.8 Priority: low
Severity: trivial Version: 4.7
Component: Shortcodes Keywords: has-patch
Focuses: docs Cc:

Description

The $attr parameter in these filters is listed as an array, but it comes from shortcode_parse_atts(), which can return an array or a string.

Attachments (1)

39294.patch (1.4 KB) - added by dhanendran 6 months ago.

Download all attachments as: .zip

Change History (4)

@dhanendran
6 months ago

#1 @dhanendran
6 months ago

  • Keywords has-patch added; needs-patch removed

Uploaded the patch for this ticket.

#2 @dd32
6 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 39665:

Shortcodes: Clarify the docs for pre_do_shortcode_tag and do_shortcode_tag.

Props dhanendran.
Fixes #39294.

#3 @dd32
6 months ago

  • Milestone changed from 4.7.1 to 4.8

After chatting with @DrewAPicture I'm punting this to 4.8.

If the docs are critical enough, Scott can manually update it, but it's obscure and trivial enough that I don't expect anyone to really run into it.

Note: See TracTickets for help on using tickets.