wrong return type in WP_User_Query::get_total()

[runciters]

As stated here: ​https://developer.wordpress.org/reference/classes/wp_user_query/get_total/

WP_User_Query::get_total() method should return an integer value, but it returns a string value:

​https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-user-query.php#L615

$total_users get its value from wpdb::get_var() which returns a string: ​https://github.com/WordPress/WordPress/blob/master/wp-includes/wp-db.php#L2270

[pento]

Thank you for the ticket and patch, @runciters!

The $total_users member is also supposed to be an int, so I think the better method would be to cast the value that $wpdb->get_var() returns as int.

If you'd like to update the patch, we can get this sorted.

[runciters]

New patch with test

[runciters]

Thank you for your reply @pento!

Here's a new updated patch (I also added a test).

[pento]

In 39915:

User Query: Cast $user_total as an int.

The $user_total member of WP_User_Query, and corresponding get_total() method, have always been documented as returning an int. $user_total, however, is populated by $wpdb->get_var(), which returns
a string (containing an integer value). Casting the return value from get_var() as an int rectifies this discrepency.

Props runciters.
Fixes #39297.