Twenty Seventeen: Allow child themes use Page Template as a front page

[sami.keijonen]

In Twenty Seventeen we use frontpage_template filter like this

function twentyseventeen_front_page_template( $template ) {
	return is_home() ? '' : $template;
}
add_filter( 'frontpage_template',  'twentyseventeen_front_page_template' );

But this means that child themes can't use Custom Page Template as a front page if they want because front-page.php would always win over any page templates.

1. Create a child theme.
2. Create custom page template.
3. Try to set that as front page. You can't because front-page.php always wins.

In client/custom sites Custom Page Template as front page would be nice to have so that you don't have to override front-page.php logic.

I'll add patch in a minute.

[JPry]

Replying to sami.keijonen:

But this means that child themes can't use Custom Page Template as a front page if they want because front-page.php would always win over any page templates.
...
I'll add patch in a minute.

No need for a patch. A child theme (or plugin) just needs one line:

remove_filter( 'frontpage_template',  'twentyseventeen_front_page_template' );

Alternatively, you can create your own function and hook it to the frontpage_template filter to override what Twenty Seventeen is doing.

[sami.keijonen]

Well that's one option. But why not set an example how it should be done for parent themes that do want to

1. have same front-page.php logic.
2. But still allow users to set Page Template as front page.

[ocean90]

@davidakennedy What are your thoughts on this?

[ocean90]

#39740 was marked as a duplicate.

[davidakennedy]

Sorry I missed this initially. I looked into this while investigating #39740.

I'm in agreement that this should be closed worksforme because this is the default behavior of WordPress. Even if the theme isn't a child theme, front-page.php will always win. That's the purpose of it.