get_pagenum_link() needs some love

[markjaquith]

get_pagenum_link() is fairly Frankenstein's Monster-ish. It isn't even using add_query_arg()

Enclosed patch is just a first attempt... I'll revisit it and clean it up, as well as address XSS-escaping.

[markjaquith]

First attempt

[ryan]

Looking good so far. It's as ugly as it is because touching it often breaks something, so watch out. :-)

[markjaquith]

Refresh

[rob1n]

Look at all that red...

[rob1n]

Patch refreshed.

[rob1n]

Patch works fine for me.

[rob1n]

(In [5454]) Bring get_pagenum_link() into this century. Props Mark Jaquith. fixes #3930

[josephscott]

This breaks the 'Previous Entries' link paging for categories.

[rob1n]

Breaks author view too.

I think remove_query_arg( 'paged' ) is removing more than paged, but I'm going to keep digging.

[rob1n]

Nope. remove_query_arg() works fine. Still digging...

[rob1n]

Alright, that seems to take care of it. Please test and report back.

[rob1n]

(In [5481]) Fix get_pagenum_link(). fixes #3930

[snakefoot]

Just tried this new get_pagenum_link() on a Wordpress 2.0 blog, and it works fine with everything except when doing a search where it adds /page/2/ instead of &paged=2 for the following pages.

Not sure if this is an issue for Wordpress 2.3

[ryan]

Yep, it does funky things to paging, especially once you get to page 3.

[rob1n]

(In [5610]) Fix get_pagenum_link() for query strings. fixes #3930