Opened 17 years ago
Closed 17 years ago
#3930 closed enhancement (fixed)
get_pagenum_link() needs some love
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.3 | Priority: | low |
Severity: | normal | Version: | 2.1.2 |
Component: | Administration | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
get_pagenum_link()
is fairly Frankenstein's Monster-ish. It isn't even using add_query_arg()
Enclosed patch is just a first attempt... I'll revisit it and clean it up, as well as address XSS-escaping.
Attachments (4)
Change History (19)
#1
@
17 years ago
Looking good so far. It's as ugly as it is because touching it often breaks something, so watch out. :-)
#5
@
17 years ago
- Keywords commit added; needs-testing removed
- Status changed from new to assigned
Patch works fine for me.
#7
@
17 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
This breaks the 'Previous Entries' link paging for categories.
#8
@
17 years ago
- Status changed from reopened to new
Breaks author view too.
I think remove_query_arg( 'paged' ) is removing more than paged, but I'm going to keep digging.
#11
@
17 years ago
- Cc rob1n added
- Keywords has-patch needs-testing added
- Status changed from new to assigned
Alright, that seems to take care of it. Please test and report back.
#13
@
17 years ago
Just tried this new get_pagenum_link() on a Wordpress 2.0 blog, and it works fine with everything except when doing a search where it adds /page/2/ instead of &paged=2 for the following pages.
Not sure if this is an issue for Wordpress 2.3
First attempt