Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#39305 closed defect (bug) (fixed)

Media: make the inline uploader button a real button

Reported by: afercia's profile afercia Owned by: afercia's profile afercia
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-screenshots has-patch semantic-buttons
Focuses: accessibility, javascript Cc:

Description

In [32467] the inline uploader button in the media template was changed in a real <button> element for better accessibility and semantics. By the way, wp.media.view.UploaderWindow still creates and appends to the body a link that, after some replacements that happen in wp.media.view.UploaderInline, is then used in the uploader.

Basically, the "Select Files" control is still a link, thus defeating the purpose of [32467]:

https://cldup.com/2T5AqAdlTk.png

Since non-link links should be buttons (see #26504 and the related tickets), this should be changed in a <button> element.

Attachments (1)

39305.diff (1.2 KB) - added by afercia 8 years ago.

Download all attachments as: .zip

Change History (3)

@afercia
8 years ago

#1 @afercia
8 years ago

  • Keywords has-patch semantic-buttons added; needs-patch removed
  • Owner set to afercia
  • Status changed from new to assigned

39305.diff makes the button a real button, no other changes.

#2 @afercia
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 40021:

Accessibility: Make the inline uploader button a real button.

See wp.media.view.UploaderWindow.

Fixes #39305.

Note: See TracTickets for help on using tickets.