Opened 10 years ago
Closed 10 years ago
#39305 closed defect (bug) (fixed)
Media: make the inline uploader button a real button
| Reported by: | afercia | Owned by: | afercia |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.8 |
| Component: | Media | Version: | |
| Severity: | normal | Keywords: | has-screenshots has-patch semantic-buttons |
| Cc: | Focuses: | accessibility, javascript |
Description
In [32467] the inline uploader button in the media template was changed in a real <button> element for better accessibility and semantics. By the way, wp.media.view.UploaderWindow still creates and appends to the body a link that, after some replacements that happen in wp.media.view.UploaderInline, is then used in the uploader.
Basically, the "Select Files" control is still a link, thus defeating the purpose of [32467]:
Since non-link links should be buttons (see #26504 and the related tickets), this should be changed in a <button> element.
Attachments (1)
Change History (3)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)

39305.diff makes the button a real button, no other changes.