</p> tag inserted in <figure>

[sujag]

since wordpress 4.7 HTML entered in "text" mode results in invalid result. Stray </p> get's inserted into <figure> after image-Element.

post content

<figure><img src="/wp-content/uploads/example.jpg" alt="something" /><figcaption>Caption</figcaption></figure>

generated markup note wrong </p> after <img>

<figure><img src="/wp-content/uploads/example.jpg" alt="something" /></p>
<figcaption>Caption</figcaption>
</figure>

Up to 4.6 this could be avoided by writing the whole figure-Element in one line, this workaround doesn't help anymore in 4.7

[azaozz]

Hi @sujag, thanks for the bug report.

Confirmed. Caused by [38592], see #4857. Without that change it inserts a <br> which is still a bug but at least doesn't visually alter the output (single closing </p> is converted to empty <p></p> in the browsers).

[pento]

I think this needs to be fixed with an exception in wpautop(), similar to object tags - the assumption is that flow elements inside of block elements (in this case, <img> inside <figure>), need to be wrapped in a <p>, but that's not the normal use case for <figure>, which is usually just an <img> and <figcaption> (in either order).

Things get a little weird with spacing inside of block elements (see #38656), the tests for this should ensure that fun combinations of spacing and ordering don't make it go haywire.

[azaozz]

Yeah, think we need an exception here too.

Perhaps can have another "group" of tags that should not be wrapped in <p> and require specific parent tags. Candidates for there would be figcaption, track, source, param.

[azaozz]

In 39307.patch: Collapse line breaks inside <figure>, and before and after <figcaption>.

This will effectively remove any <p> inside of <figure>, above or below <figcaption> (which are allowed but very rarely used). These weren't working properly before 4.7, so don't expect it to cause any regressions.

[pbearne]

I am seeing similar problem in this ticket https://core.trac.wordpress.org/ticket/39377

[pbearne]

I have added a test for this while I was creating one the other ticket

[MattyRob]

Related #15918

[azaozz]

In 39307.2.patch: similar to 39307.patch but does not remove line breaks from directly inside <figure> tags. This is closer to the previous behavior.

Still needs testing with older posts containing these tags to confirm there are no regressions.

[azaozz]

Seems better to try to test this more before adding in a dot release.

[azaozz]

In 39912:

Formatting: fix wpautop() to stop adding paragraph tags around <figcaption>.

Fixes #39307 for trunk.

[azaozz]

Reopen for 4.7.2 consideration.

[pbearne]

@azaozz do you need new unit tests for this?

[azaozz]

Replying to pbearne:
Was looking at "unifying" the tests for figcaption, track, source, param, as they are almost identical. But probably better to keep it simple and easier to read :)

[azaozz]

In 39914:

Tests: wpautop() should not add extra </p> before <figcaption>.

Props pbearne.
See #39307.

[jbpaul17]

Per @jnylen0 in today's bug scrub in #core: Adding fixed-major keyword as this ticket has a couple of commits already.

[dd32]

@azaozz Is this clear for 4.7.x? or is extra work and/or testing needed?

[azaozz]

Replying to dd32:
Yes, should be good for 4.7.x. There are still couple of very rare cases introduced by [38592], but they are much harder to fix.

[dd32]

In 40091:

Formatting: fix wpautop() to stop adding paragraph tags around <figcaption>.

Props azaozz, pbearne for tests.
Merges [39912], [39914] to the 4.7 branch.
Fixes #39307 for 4.7.

[pento]

#27559 was marked as a duplicate.