Changes between Version 2 and Version 3 of Ticket #39321, comment 2
- Timestamp:
- 12/23/2016 12:59:39 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #39321, comment 2
v2 v3 3 3 I was programmatically importing and updating data when I noticed this. With this part: 4 4 `Your change would make this worse, since the structure of the URL would be different for authorless revisions: example.com/authorname/postname vs example.com/postname. Perhaps revisions should always have permalinks of the form ?p=123, as is the case with draft, pending, auto-draft, and future.` 5 Not sure that's actually true, because in this situation `$author = $authordata->user_nicename;` never actually worked since `post_author=0`, `$authordata` is not an object and `$authordata->user_nicename;` is just `NULL`, so it would actually just remainthe same but with the added bonus of not throwing a PHP Notice :-)5 Not sure that's actually true, because in this situation `$author = $authordata->user_nicename;` never actually worked when `post_author=0`, `$authordata` is not an object and `$authordata->user_nicename;` is just `NULL`, so my change just leave it the same but with the added bonus of not throwing a PHP Notice :-) 6 6 7 7 I like the idea of reverting to non-pretty permalinks for revisions as I think this is the safest course of action and follows suit with draft, pending, auto-draft statuses.