Opened 6 years ago
Closed 6 years ago
#39335 closed defect (bug) (fixed)
Twenty Seventeen: customize-controls.js incorrectly assumes theme_options section is always present
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.7.1 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Bundled Theme | Keywords: | has-patch fixed-major |
Focuses: | Cc: |
Description (last modified by )
Plugins can de-register panels, sections, controls, and settings that are registered by default by core and by themes. As such, themes should use the deferred pattern to interact with such constructs. This is particularly an issue in Twenty Seventeen and now it assumes the theme_options
section is present.
Originally reported at https://github.com/xwp/wp-customizer-blank-slate/issues/8
Attachments (1)
Change History (8)
#1
@
6 years ago
- Description modified (diff)
- Keywords has-patch added
- Owner set to davidakennedy
- Status changed from new to reviewing
#4
@
6 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Not 100% sure if this is the right procedure for bundled themes, but re-opening for committing into 4.7 branch.
#5
@
6 years ago
Not 100% sure if this is the right procedure for bundled themes, but re-opening for committing into 4.7 branch.
FTR, yes, Twenty Seventeen fixes will need merging to the 4.7 branch too. @davidakennedy I'm happy to take care of that in one of my merge-storms.
Thanks for the report and patch @westonruter! This looks good and worked well in my testing.