WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 7 months ago

#39352 new defect (bug)

Customize: menu widgets have two edit shortcuts

Reported by: sirbrillig Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords:
Focuses: Cc:
PR Number:

Description

r39622 fixes the edit shortcut for menus inside widgets, but that still leaves two edit shortcuts for those partials, generally with one on top of the other. Right now the menu shortcut is on top of the widget shortcut, so I was thinking it might be worth while to hide one, but I wonder which one is the better experience for users?

Clicking on the menu shortcut brings up the editor for that menu.

https://cldup.com/7lTAzaHguo.png

Clicking on the widget shortcut brings up the widget settings, which allow changing which menu is displayed there.

https://cldup.com/mWvyLgbTc1.png

It seems to me that both could be what a user might be looking for, but I think we can really only have one. Since you can click the "Edit Menu" button to get from the widget settings to the menu settings and not the other way around, I suggest we hide the menu shortcut, but I'm open to a dissenting opinion.

cc: @folletto and @melchoyce for a UX perspective

Split from #39101

Attachments (3)

menu-widget-menu-control.png (50.2 KB) - added by sirbrillig 3 years ago.
Menu widget menu control
menu-widget-widget-control.png (41.9 KB) - added by sirbrillig 3 years ago.
Menu widget widget control
39352.diff (866 bytes) - added by sirbrillig 3 years ago.
Prevent adding edit shortcut for nav menus inside widgets

Download all attachments as: .zip

Change History (6)

@sirbrillig
3 years ago

Menu widget menu control

@sirbrillig
3 years ago

Menu widget widget control

#1 @sirbrillig
3 years ago

  • Summary changed from Customize: menu widget have two edit shortcuts to Customize: menu widgets have two edit shortcuts

#2 @folletto
3 years ago

Since you can click the "Edit Menu" button to get from the widget settings to the menu settings and not the other way around, I suggest we hide the menu shortcut, but I'm open to a dissenting opinion.

I'd wait for Mel's review too, but my opinion is that a better solution would require more design and rework, so this is probably the best approach we have right now for the reason you have outlined.
It's also slightly less incongruent having all the "widget" items to have the same kind of interaction to start with.

tl;dr: hide the menu shortcut.

#3 @sirbrillig
3 years ago

tl;dr: hide the menu shortcut.

I'll attach the patch that does that in case we decide to go that route.

@sirbrillig
3 years ago

Prevent adding edit shortcut for nav menus inside widgets

Note: See TracTickets for help on using tickets.