Customize: menu widgets have two edit shortcuts

[sirbrillig]

r39622 fixes the edit shortcut for menus inside widgets, but that still leaves two edit shortcuts for those partials, generally with one on top of the other. Right now the menu shortcut is on top of the widget shortcut, so I was thinking it might be worth while to hide one, but I wonder which one is the better experience for users?

Clicking on the menu shortcut brings up the editor for that menu.

Clicking on the widget shortcut brings up the widget settings, which allow changing which menu is displayed there.

It seems to me that both could be what a user might be looking for, but I think we can really only have one. Since you can click the "Edit Menu" button to get from the widget settings to the menu settings and not the other way around, I suggest we hide the menu shortcut, but I'm open to a dissenting opinion.

cc: @folletto and @melchoyce for a UX perspective

Split from #39101

[sirbrillig]

Menu widget menu control

[sirbrillig]

Menu widget widget control

[folletto]

Since you can click the "Edit Menu" button to get from the widget settings to the menu settings and not the other way around, I suggest we hide the menu shortcut, but I'm open to a dissenting opinion.

I'd wait for Mel's review too, but my opinion is that a better solution would require more design and rework, so this is probably the best approach we have right now for the reason you have outlined.
It's also slightly less incongruent having all the "widget" items to have the same kind of interaction to start with.

tl;dr: hide the menu shortcut.

[sirbrillig]

tl;dr: hide the menu shortcut.

I'll attach the patch that does that in case we decide to go that route.

[sirbrillig]

Prevent adding edit shortcut for nav menus inside widgets

[celloexpressions]

I'm not personally bothered by the double icons since they're both visible in a nested way... but I know exactly why there are two and what each does. It would be good to get feedback from users that may be less familiar with what's actually happening here.

I also wonder navigation blocks might replace most instances of the menu widget moving forward.