WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Last modified 8 years ago

#39356 new defect (bug)

grunt precommit doesn't work on full checkouts of develop.svn

Reported by: pento's profile pento Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

To reproduce:

$ svn co https://develop.svn.wordpress.org/ develop.svn
$ cd develop.svn/branches/4.7

Edit a file in the 4.7 branch, then run grunt precommit. It fails with this message:

$ grunt precommit
Running "precommit" task
Fatal error: This WordPress install is not under version control.

Attachments (1)

39356.diff​ (316 bytes) - added by netweb 8 years ago.

Download all attachments as: .zip

Change History (4)

@netweb
8 years ago

#1 @netweb
8 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 4.8

I've added a search path for the .svn folder two levels up in 39356.diff​, this works fine for both svn co https://develop.svn.wordpress.org/ and svn co https://develop.svn.wordpress.org/trunk checkouts

Note: A Git equivalent isn't required as Git handles branches differently as the .git is always present at the root level irrespective of the checked out branch.

This ticket was mentioned in ​Slack in #core by flixos90. ​View the logs.
8 years ago

#3 @flixos90
8 years ago

  • Milestone changed from 4.8 to Future Release
Note: See TracTickets for help on using tickets.