Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39358, comment 12


Ignore:
Timestamp:
12/22/2016 03:46:55 PM (7 years ago)
Author:
joemcgill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #39358, comment 12

    initial v1  
    1111c) I don't think exact matches are helpful here for reasons illustrated by the use case above. Often, it's not that someone knows the exact name of a file, but needs to search by partial information included in a file name. In my mind, this is the least applicable option.
    1212
    13 d) Storing the information in another way seems like the best option, as your example using GUID demonstrates. I was hesitant in using GUID because we've not relied on the GUID for file names since #7622 and I assume some plugins modify the filename while ignoring the GUID altogether. Perhaps it is worth sacrificing those edge cases for the performance benefits? Here it's worth noting that there is a request to also make image `alt` attributes searchable from the media library, and alt information is similarly stored as postmeta. This cannot as easily be searched from our current post schema.
     13d) Storing the information in another way seems like the best option, as your example using GUID demonstrates. I was hesitant in using GUID because we've not relied on the GUID for file names since #7622 and I assume some plugins modify the filename as postmeta while ignoring the GUID altogether. Perhaps it is worth sacrificing those edge cases for the performance benefits? Here it's worth noting that there is a request to also make image `alt` attributes searchable from the media library, and alt information is similarly stored as postmeta. This cannot as easily be searched from our current post schema.