#39365 closed defect (bug) (fixed)
Site info always displays main site URL as http even if the URL scheme is https
| Reported by: | greatislander | Owned by: | flixos90 |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.8 |
| Component: | Networks and Sites | Version: | 4.5 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | multisite |
Description
Since [36682], the non-editable main site URL is always displayed as http in /wp-admin/network/site-info.php. The URL is constructed by applying esc_url() to a concatenated string composed of $details->domain and $details->path, which always results in an http URL because no URL scheme is provided. This is counterintuitive, as site-info.php reflects the actual URL scheme for all the other sites in a network.
Attachments (2)
Change History (9)
#1
@
10 years ago
The attached patch normalizes the main site URL display in site-info.php to include the URL scheme from $parsed_scheme as is the case for all other sites in a network.
#2
@
10 years ago
- Focuses administration removed
- Milestone Awaiting Review → Future Release
- Version trunk → 4.5
Thanks for the patch @greatislander!
I think we should continue to use esc_url() to escape the entire URL here instead of using esc_attr() on the individual parts - other than that this looks like a solid change to make. :)
Patch from https://github.com/WordPress/WordPress/pull/262