Site info always displays main site URL as http even if the URL scheme is https

[greatislander]

Since [36682], the non-editable main site URL is always displayed as http in /wp-admin/network/site-info.php. The URL is constructed by applying esc_url() to a concatenated string composed of $details->domain and $details->path, which always results in an http URL because no URL scheme is provided. This is counterintuitive, as site-info.php reflects the actual URL scheme for all the other sites in a network.

[greatislander]

Patch from ​https://github.com/WordPress/WordPress/pull/262

[greatislander]

The attached patch normalizes the main site URL display in site-info.php to include the URL scheme from $parsed_scheme as is the case for all other sites in a network.

[flixos90]

Thanks for the patch @greatislander!

I think we should continue to use esc_url() to escape the entire URL here instead of using esc_attr() on the individual parts - other than that this looks like a solid change to make. :)

[greatislander]

Patch from ​https://github.com/WordPress/WordPress/pull/263

[greatislander]

@flixos90 Updated as per your feedback.

[flixos90]

In 39930:

Multisite: Display correct scheme for the main site in site-info.php.

Props greatislander.
Fixes #39365.

[flixos90]

#39786 was marked as a duplicate.

[ocean90]

#40235 was marked as a duplicate.