Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39380


Ignore:
Timestamp:
12/24/2016 03:51:33 PM (5 years ago)
Author:
dshanske
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #39380

    • Property Milestone changed from Awaiting Review to 4.7.1
    • Property Summary changed from wp_update_comment strips data from passed array to wp_update_comment can cause database error with new filter
  • Ticket #39380 – Description

    initial v1  
    33However, wp_array_slice_assoc is called to filter keys out of the array before it is passed to both.
    44
    5 It should be called only to filter the data going into the database. By adding a key to the array at the filter, for example, you can cause a database error.
     5It should be called after and only to filter the data going into the database. By adding a key to the array at the filter you can cause a database error.
    66
    7 By removing extra keys from the data before it hits edit_comment, it makes it impossible to pass data to be saved as metadata.
     7By removing extra keys from the data before it hits edit_comment, it also makes it impossible to pass data to be saved as metadata.