Context Navigation

← Previous Ticket
Next Ticket →

#39384 closed defect (bug) (fixed)

Twenty Seventeen: Navbar z-index issue

Reported by:	halgatewood	Owned by:	ianbelanger
Priority:	normal	Milestone:	5.5
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	css

Description

The current z-index for the fixed navigation is 7. This seems a bit low as it should be above all other items on the page. For instance this widget getting mixed up with the navigation items:

Something much higher may be appropriate:

.site-navigation-fixed.navigation-top { z-index: 9999; }

Thanks,
Hal Gatewood

Attachments (2)

39384.patch (418 bytes ) - added by poena 6 years ago.: Updates z-index for the fixed menu.
39384.1.diff (418 bytes ) - added by sinatrateam 6 years ago.: Updates z-index to 1000 to avoid issues with lightboxes

Download all attachments as: .zip

Change History (9)

#1 @justnorris
9 years ago

Type enhancement → defect (bug)

I just ran into the same issue.

I think z-index: 9999 can be an overkill, and maybe even override some lightboxes, but z-index:7 is definitely way too low for a sticky menu.

Maybe it should be set to around 500 - 1000 ?

Last edited 9 years ago by justnorris (previous) (diff)

@poena
6 years ago

Attachment 39384.patch added

Updates z-index for the fixed menu.

#2 @poena
6 years ago

Component Themes → Bundled Theme
Focuses css added
Keywords has-patch added

Tested and added the small patch.
Changed the component to Bundled Theme.

@sinatrateam
6 years ago

Attachment 39384.1.diff added

Updates z-index to 1000 to avoid issues with lightboxes

#3 @ianbelanger
6 years ago

Focuses template removed
Keywords commit added
Milestone Awaiting Review → 5.5
Owner set to ianbelanger
Status new → reviewing

Reviewing for commit.

#4 @ianbelanger
6 years ago

Summary TwentySeventeen Navbar z-index → Twenty Seventeen: Navbar z-index issue

#5 @ianbelanger
6 years ago

Resolution → fixed
Status reviewing → closed

In 48061:

Bundled Themes: Twenty Seventeen Navbar z-index issue.

Fixes navbar z-index issue by upping the z-index value to 1000 from 7.

Props halgatewood, justnorris, poena, sinatrateam.
Fixes #39384.

#6 @ianbelanger
6 years ago

Keywords fixed-major added; commit removed
Milestone 5.5 → 5.4.3
Resolution fixed
Status closed → reopened

Reopening for backport.

#7 @desrosj
6 years ago

Keywords fixed-major removed
Milestone 5.4.3 → 5.5
Resolution → fixed
Status reopened → closed

With 5.5 just under 5 weeks away, there is no 5.4.3 planned. Moving back to the 5.5 milestone.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#39384 closed defect (bug) (fixed)

Twenty Seventeen: Navbar z-index issue

Description

Attachments (2)

Change History (9)

#1 @justnorris 9 years ago

@poena 6 years ago

#2 @poena 6 years ago

@sinatrateam 6 years ago

#3 @ianbelanger 6 years ago

#4 @ianbelanger 6 years ago

#5 @ianbelanger 6 years ago

#6 @ianbelanger 6 years ago

#7 @desrosj 6 years ago