WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 months ago

#39384 closed defect (bug) (fixed)

Twenty Seventeen: Navbar z-index issue

Reported by: halgatewood Owned by: ianbelanger
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:

Description

The current z-index for the fixed navigation is 7. This seems a bit low as it should be above all other items on the page. For instance this widget getting mixed up with the navigation items:

https://halgatewood.com/wp-content/uploads/2016/12/twentyseventeen-zindex.jpg

Something much higher may be appropriate:

.site-navigation-fixed.navigation-top { z-index: 9999; }

Thanks,
Hal Gatewood

Attachments (2)

39384.patch (418 bytes) - added by poena 6 months ago.
Updates z-index for the fixed menu.
39384.1.diff (418 bytes) - added by sinatrateam 4 months ago.
Updates z-index to 1000 to avoid issues with lightboxes

Download all attachments as: .zip

Change History (9)

#1 @justnorris
3 years ago

  • Type changed from enhancement to defect (bug)

I just ran into the same issue.

I think z-index: 9999 can be an overkill, and maybe even override some lightboxes, but z-index:7 is definitely way too low for a sticky menu.

Maybe it should be set to around 500 - 1000 ?

Last edited 3 years ago by justnorris (previous) (diff)

@poena
6 months ago

Updates z-index for the fixed menu.

#2 @poena
6 months ago

  • Component changed from Themes to Bundled Theme
  • Focuses css added
  • Keywords has-patch added

Tested and added the small patch.
Changed the component to Bundled Theme.

@sinatrateam
4 months ago

Updates z-index to 1000 to avoid issues with lightboxes

#3 @ianbelanger
4 months ago

  • Focuses template removed
  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.5
  • Owner set to ianbelanger
  • Status changed from new to reviewing

Reviewing for commit.

#4 @ianbelanger
4 months ago

  • Summary changed from TwentySeventeen Navbar z-index to Twenty Seventeen: Navbar z-index issue

#5 @ianbelanger
4 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48061:

Bundled Themes: Twenty Seventeen Navbar z-index issue.

Fixes navbar z-index issue by upping the z-index value to 1000 from 7.

Props halgatewood, justnorris, poena, sinatrateam.
Fixes #39384.

#6 @ianbelanger
4 months ago

  • Keywords fixed-major added; commit removed
  • Milestone changed from 5.5 to 5.4.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#7 @desrosj
4 months ago

  • Keywords fixed-major removed
  • Milestone changed from 5.4.3 to 5.5
  • Resolution set to fixed
  • Status changed from reopened to closed

With 5.5 just under 5 weeks away, there is no 5.4.3 planned. Moving back to the 5.5 milestone.

Note: See TracTickets for help on using tickets.