WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#3939 closed defect (bug) (fixed)

unconditional call to imageantialias() in admin-functions.php near line 2090

Reported by: jeppe Owned by: rob1n
Milestone: 2.2 Priority: low
Severity: minor Version: 2.1.2
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

imageantialias() is called without first checking if it's available with function_exists.
It seems it's only available with the PHP bundled GD.

Attachments (1)

3939.diff (476 bytes) - added by rob1n 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 @foolswisdom8 years ago

  • Milestone set to 2.2

jeppe what version of WordPress are you running? Did you see if this problem still exists on trunk? SVN revision?

Thank you!

comment:2 @rob1n8 years ago

  • Keywords dev-feedback 2nd-opinion added; gd removed
  • Owner changed from anonymous to rob1n
  • Priority changed from normal to low
  • Severity changed from normal to minor
  • Status changed from new to assigned
  • Version set to 2.1.2

You *should* be using PHP's bundled GD library, anyhow.

Since PHP 4.3 there is a bundled version of the GD lib. This bundled version has some additional features like alpha blending, and should be used in preference to the external library since its codebase is better maintained and more stable. (from http://us3.php.net/manual/en/ref.image.php).

I guess we could add in a function_exists() check, though. Seeing as imageantialias() isn't necessary.

@rob1n8 years ago

comment:3 @rob1n8 years ago

  • Keywords has-patch commit added; dev-feedback 2nd-opinion removed

Discussed with Ryan, verdict was to add a function_exists().

comment:4 @ryan8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5016]) Make sure imageantialias exists. Props rob1n and jeppe. fixes #3939

Note: See TracTickets for help on using tickets.