Adding sms to list of allowed protocol

[rilwis]

Currently, the list of allowed protocols is provided in the function wp_allowed_protocols() . However, the list doesn’t have the "sms" protocol.

This is a new protocol and very useful for mobile users as they can send SMS when clicking the link. It’s very similar to "tel" protocol where users can call a person when clicking the link.

Reference:

​https://developer.apple.com/library/content/featuredarticles/iPhoneURLScheme_Reference/SMSLinks/SMSLinks.html
​http://stackoverflow.com/questions/5721437/how-to-initiate-send-sms-from-a-html5-webpage-using-devices-native-functions

[agusmu]

personally, I like this idea.

the problems are:
(1) sms protocol is very buggy
(2) it has different format for different devices (android, iphone, old iphone iOS7/8, etc)
(3) it doesn't work on facebook in-app browser

[rilwis]

Thanks agusmu for your comment.

I think the format of the protocol is not a problem. All of them use the same "sms:" protocol, the only difference is the following text. I just mean we add the protocol, not for supporting the links.

If we add the protocol, the devices which support that (iPhone, Android) will be able to open the SMS/Phone app and do its job. Think about "skype:" protocol, it works only if your computer installed Skype.

This ticket is about supporting the protocol, not making it work. Making it work is the totally different story and in my opinion, is out of the scope of WordPress itself.

[keraweb]

Added 'skype' and 'sms' to the protocols array.

[keraweb]

I agree with @rilwis. Whether the end user can use it is not up to WordPress. WordPress should IMO allow site owners to choose themselves if they want to use these protocols or not. I've also added skype since that wasn't in there as well.

[SergeyBiryukov]

#46579 was marked as a duplicate.

[kraftbj]

While I can support the SMS protocol being added, skype causes me pause—why not add tg for Telegram? It can get to be a long list of particular program-specific protocols.

I would suggest only adding SMS.

Additional ref: ​https://www.ietf.org/rfc/rfc5724.txt which defines the sms:// protocol.

[kraftbj]

Only add SMS and remove extra character added to line 1 in the original patch. Updates @since.

[whyisjake]

Added a test case for SMS.

[whyisjake]

In 46172:

Add SMS to the list of allowed protocols.

This commit expands the list of allowed protocols. It adds the sms:// which can be used to open meessaging clients for mobile users.

Props rilwis, kraftbj

Fixes #39415

[desrosj]

Mentioned in the Miscellaneous Developer Focused Changes dev note for 5.3: ​https://make.wordpress.org/core/2019/10/15/miscellaneous-developer-focused-changes-in-5-3/