WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#39444 closed defect (bug) (fixed)

Text Decoration Underline removes on hover in Customizer

Reported by: monikarao Owned by: westonruter
Milestone: 4.7.1 Priority: normal
Severity: normal Version: trunk
Component: Customize Keywords: has-patch commit fixed-major
Focuses: ui Cc:

Description

I noticed that the action link "Delete Menu" in Customizer has text underline property. This underline gets removed on hover over the link.

But in all other action links that have underline remain same on the hover.

CSS class I am referring to this bug: .menu-delete

On hover:
.menu-delete:focus, .menu-delete:hover

Attachments (3)

control.png (13.0 KB) - added by monikarao 4 months ago.
Normal state
control-hover.png (22.7 KB) - added by monikarao 4 months ago.
Hover state
39444.diff (384 bytes) - added by monikarao 4 months ago.
Patch attached

Download all attachments as: .zip

Change History (12)

@monikarao
4 months ago

Normal state

@monikarao
4 months ago

Hover state

@monikarao
4 months ago

Patch attached

#1 @monikarao
4 months ago

  • Keywords has-patch added
  • Version set to trunk

Patch 39444.diff is attached!

#2 @karmatosed
4 months ago

  • Keywords commit added

@monikarao thanks for this, I actually agree that there is an existing pattern to not remove the underline. For example, on posts when you edit and the 'move to trash' link.

Further confusion under the Customizer comes when you click widgets and the links have no underline at all. There seems like an opportunity to also make sure that happens, in another ticket maybe.

@westonruter pinging you here to get a commit on this as it's a small but good tidy up.

#3 @westonruter
4 months ago

@karmatosed is this not a regression introduced in #37527 for 4.7? As such should we not milestone this for 4.7.1?

#4 @karmatosed
4 months ago

  • Milestone changed from Awaiting Review to 4.7.1

If it is a regression yes we should, you are totally correct.

#5 @westonruter
4 months ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 39677:

Customize: Prevent removal of underline upon hover/focus for nav menu deletion links.

Props monikarao.
Amends [38503].
See #37527.
Fixes #39444.

#6 @westonruter
4 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for 4.7.1

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


4 months ago

#8 @celloexpressions
4 months ago

Looks good to be as well, +1 for fixing the regression in 4.7.1.

#9 @dd32
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 39696:

Customize: Prevent removal of underline upon hover/focus for nav menu deletion links.

Props monikarao.
Amends [38503].
See #37527.
Merges [39677] to the 4.7 branch.
Fixes #39444.

Note: See TracTickets for help on using tickets.