Improvement to the get_the_posts_navigation

[thirumani02]

https://core.trac.wordpress.org/browser/tags/4.7/src/wp-includes/link-template.php Here at get_the_posts_navigation the function check global wp query(Globals['wp_query'\]) for displaying markup. But in many cases we may need to display the navigation for custom wp query which has unique query options(max_num_page, post_per_page). So it would be great, if we can check the our custom query's max_num_page.

Hope it make sense.

Thank you

[Howdy_McGee]

Additional max_num_pages args

[Howdy_McGee]

This patch adds additional $args to the get_the_posts_navigation() and get_the_posts_pagination() functions to handle max_num_pages. Instead of defaulting to the global $wp_query->max_num_pages you can pass a defined integer:

get_the_posts_navigation( array( 'max_num_pages' => 3 ) );
get_the_posts_pagination( array( 'max_num_pages' => 3 ) );

I've tested this patch with a custom query and the default posts.

[davidbaumwald]

@Howdy_McGee Can you refresh this patch against the /src/ dir in trunk? There are also a couple WPCS issues to resolve as well.

[Howdy_McGee]

Revised and linted.

[garrett-eclipse]

Minor Refresh

[garrett-eclipse]

The patch is looking great @Howdy_McGee dropping the refresh label. In 39447.3.diff the only change I made was to add a missing period to the first new docblock sentence and recreate the patch from the root of the repo so it applies cleanly.

[SergeyBiryukov]

It seems like get_the_posts_pagination() would benefit from a similar change for consistency.

Adding a unit test might also be a good idea. Moving to the next release for now.

[noisysocks]

Hi @Howdy_McGee @Garrett-eclipse, are you still able to work on this for 5.7?

Adding needs-patch and needs-unit-tests to reflect the changes requested above.

[audrasjb]

As per today's bug scrub, let's move this ticket to Future release so it can be handled in time for WP 5.8. If we have a patch and unit tests in time for 5.7 beta 1, please feel free to move it back to milestone 5.7.

[Howdy_McGee]

New $total argument for get_the_posts_pagination( $args )