WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#39469 closed defect (bug) (fixed)

Different first char case of phpmailer send method

Reported by: michalzuber Owned by: dd32
Priority: normal Milestone: 4.8
Component: Mail Version: 4.8
Severity: trivial Keywords: has-patch commit
Cc: Focuses:

Description

At https://core.trac.wordpress.org/browser/trunk/src/wp-includes/pluggable.php#L481 is Send(), but at https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-phpmailer.php#L1207 is send()

I suggest lowercasing in pluggable.php to avoid upstream inconsistency ​https://github.com/PHPMailer/PHPMailer/blob/v5.2.20/class.phpmailer.php#L1207

Attachments (1)

39469.diff​ (490 bytes ) - added by michalzuber 10 years ago.
Lowercase send() in pluggable.php

Download all attachments as: .zip

Change History (4)

@michalzuber
10 years ago

Lowercase send() in pluggable.php

#1 @dd32
10 years ago

  • Keywords has-patch commit added
  • Severity normal → trivial

PHP method names are case insensitive, but sure, nothing wrong with changing this.

#2 @dd32
10 years ago

  • Milestone Awaiting Review → 4.8

#3 @dd32
10 years ago

  • Owner set to dd32
  • Resolution → fixed
  • Status new → closed

In 39691:

Mail: In PHPMailer 5.2.7 the case of the Send() method changed to send(), update our call for consistency with the library.

Props michalzuber.
Fixes #39469.

Note: See TracTickets for help on using tickets.