#39486 closed defect (bug) (fixed)
In Travis, skip some tests when not on trunk
Reported by: | jorbin | Owned by: | johnbillion |
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | 3.9 |
Component: | Build/Test Tools | Keywords: | |
Focuses: | Cc: |
Description
There are some tests that are around to serve as reminders for modern development such as to ensure the copy write year is updated and ensure that the readme PHP recommendation matches the recommendation on wordpress.org
For the automated running of tests, tests such as these should be skipped by detecting the branch we are on in travis, and only running the test when the branch is master.
We can use travis enviornement variable TRAVIS_BRANCH
to detect the branch.
Attachments (2)
Change History (26)
#2
@
8 years ago
In this first pass 39486.diff
- A new PHPUnit Grunt task is added
grunt phpunit:trunk-only
- PHPUnit tests that should be excluded from Travis CI branch jobs should be added to the
@group trunk-only
Notes: Untested at this stage, thinking out loud in a patch :)
This ticket was mentioned in Slack in #core by joemcgill. View the logs.
8 years ago
#4
@
8 years ago
- Summary changed from In Travis, skip some tests when not on truck to In Travis, skip some tests when not on trunk
#5
follow-up:
↓ 6
@
8 years ago
I took an alternative take that minimizes the changes needed. Feedback welcome.
#6
in reply to:
↑ 5
;
follow-up:
↓ 7
@
8 years ago
Replying to jorbin:
I took an alternative take that minimizes the changes needed. Feedback welcome.
Neat +1
Can you remove the erroneous extras in the 39486.2.diff and go forth and commit :)
#7
in reply to:
↑ 6
;
follow-up:
↓ 8
@
8 years ago
Replying to netweb:
Can you remove the erroneous extras in the 39486.2.diff and go forth and commit :)
Now I'm wondering if I broke grunt upload_patch
at some point since those changes don't appear during svn diff
. ¯\_(ツ)_/¯
#8
in reply to:
↑ 7
@
8 years ago
Replying to jorbin:
Now I'm wondering if I broke
grunt upload_patch
at some point since those changes don't appear duringsvn diff
. ¯\_(ツ)_/¯
Not sure, but the "extras" in the patch looked like they were from /build
, but in fact they are prefixed from /src
Had you performed any build/src juggling recently?
I'm good with this - I came to the same conclusion myself last night after dealing with the failures.
If someone wants to put together a patch for trunk which skips these misc tests, I'll test and backport it to all the relevant branches.