WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

#39488 closed defect (bug) (fixed)

Twenty Seventeen: Type and name in @param tags are the wrong way around

Reported by: ocean90 Owned by: SergeyBiryukov
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: good-first-bug has-patch
Focuses: docs Cc:

Description

Example:

<?php
/**
 * Filter number of front page sections in Twenty Seventeen.
 *
 * @since Twenty Seventeen 1.0
 *
 * @param $num_sections integer
 */
$num_sections = apply_filters( 'twentyseventeen_front_page_sections', 4 );

integer should be int and the whole tag should be @param int $num_sections <description>.

Attachments (5)

39488.patch (1.7 KB) - added by ketuchetan 6 months ago.
Added patch
39488.2.patch (1.6 KB) - added by priyankabehera155 6 months ago.
Description added
39488.3.patch (1.7 KB) - added by ketuchetan 6 months ago.
39488.4.patch (1.7 KB) - added by Jaydeep Rami 6 months ago.
added the param for the twentyseventeen_content_width, twentyseventeen_custom_colors_saturation and twentyseventeen_social_links_icons
39488.5.patch (1.7 KB) - added by BharatKambariya 6 months ago.
Added twentyseventeen_content_width, twentyseventeen_custom_colors_saturation and twentyseventeen_social_links_icons

Download all attachments as: .zip

Change History (11)

@ketuchetan
6 months ago

Added patch

#1 @ketuchetan
6 months ago

  • Keywords has-patch added; needs-patch removed

I have modified the documentation @param

@priyankabehera155
6 months ago

Description added

@ketuchetan
6 months ago

#2 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 39732:

Twenty Seventeen: Correct @param entry for twentyseventeen_front_page_sections filter.

Props ketuchetan, priyankabehera155.
Fixes #39488.

#3 @ocean90
6 months ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

There is also twentyseventeen_content_width, twentyseventeen_custom_colors_saturation and twentyseventeen_social_links_icons.

@Jaydeep Rami
6 months ago

added the param for the twentyseventeen_content_width, twentyseventeen_custom_colors_saturation and twentyseventeen_social_links_icons

#4 @Jaydeep Rami
6 months ago

  • Keywords has-patch added; needs-patch removed

Added the patch for the twentyseventeen_content_width, twentyseventeen_custom_colors_saturation and twentyseventeen_social_links_icons

@BharatKambariya
6 months ago

Added twentyseventeen_content_width, twentyseventeen_custom_colors_saturation and twentyseventeen_social_links_icons

#5 @BharatKambariya
6 months ago

Added modified patch

#6 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 39733:

Twenty Seventeen: Correct @param entries for twentyseventeen_content_width, twentyseventeen_custom_colors_saturation and twentyseventeen_social_links_icons filters.

Props Jaydeep Rami, BharatKambariya.
Fixes #39488.

Note: See TracTickets for help on using tickets.