JS Error: Cannot read property 'models' of undefined in wp-includes/js/media-views.js at line no 7727

[chandrapatel]

Below are the steps to reproduce this JS error.

1. Add this code in plugin or in mu-plugins directory.

<?php

function cmu_media_menu( $tabs ) {
    $newtab = array( 'cmu' => 'Custom Media Upload' );
    return array_merge( $tabs, $newtab );
}

add_filter( 'media_upload_tabs', 'cmu_media_menu' );

function cmu_media_handle() {
    echo 'Hey Everyone !';
}

add_action( 'media_upload_cmu', function() {
    return wp_iframe( 'cmu_media_handle' );
} );

2. Create New Post -> Click on Add Media -> Click on Custom Media Upload and than close pop-up.

3. Now click on Featured Image than click on Upload Files tab and than try to upload file. You will get JS error as mentioned above.

selection and library state are not set for custom tabs.

Simple solution is like add if condition. I've added initial patch.

[adamsilverstein]

@chandrapatel Thanks for your detailed bug report and the patch. The check seems quite reasonable and appropriate here.

I was able to reproduce the issue you described and see the error in my console when attempting to upload, and I am unable to upload images.

After applying your patch I verified I no longer see the console message, and image uploading works fine.

[wonderboymusic]

In 40050:

Media: in wp.media.view.Toolbar.refresh(), check for a selection before iterating over models.

Props chandrapatel.
Fixes #39511.