Make WordPress Core

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#39539 closed enhancement (invalid)

Combine and simplify strings

Reported by: presskopp's profile Presskopp Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.8
Component: Text Changes Keywords:
Focuses: Cc:


We made the "unknown post type" invalid, see #39171

We could take this a step further and change

unknown to invalid in:

"Unknown Feed"

and maybe

"Unknown action."

Also the (missing) period could be discussed in those strings.

Attachments (1)

39539.diff (967 bytes) - added by lukecavanagh 7 years ago.
Basic patch

Download all attachments as: .zip

Change History (6)

7 years ago

Basic patch

#1 in reply to: ↑ description @SergeyBiryukov
7 years ago

Replying to Presskopp:

We made the "unknown post type" invalid, see #39171

The only reason for [39756] was to merge similar strings with the same meaning and remove duplicates. I don't see a benefit in changing other strings just to get rid of "unknown".

Moreover, an empty feed title doesn't make the feed invalid, so the existing string is more accurate.

#2 @Presskopp
7 years ago

I noticed there are much more instances of anything 'invalid' and only a few 'unknown' things. But following your input I think the ticket can be closed as wontfix.

Last edited 7 years ago by Presskopp (previous) (diff)

#3 @Presskopp
6 years ago

  • Keywords close added
  • Resolution set to invalid
  • Status changed from new to closed

let's close this, about the periods, see #42735

#4 @netweb
6 years ago

  • Milestone Awaiting Review deleted

#5 @netweb
6 years ago

  • Keywords close removed
Note: See TracTickets for help on using tickets.