WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#39547 new defect (bug)

options-permalink.php throws incorrect "You should update..." notice on multisite

Reported by: boonebgorges Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.6
Component: Permalinks Keywords: has-patch
Focuses: administration Cc:
PR Number:

Description

Setup:

  1. Subdirectory multisite installation on Apache with mod_rewrite
  2. /.htaccess/ and / should *not* be writable by the webserver
  3. On a secondary site (NOT blog 1), Dashboard > Options > Permalinks, ensure that you have pretty permalinks enabled (not index.php, not default)
  4. Click Save Changes without making any modifications
  5. You should see a green notice "You should update your .htaccess file now"

Prior to #37380, saving existing settings would result in a success notice. However, #37380 just fixed a bug in the implementation of [37747], so I think the bug comes from #35936.

Prior to [37747], the "You should update..." family of notices was never shown when is_multisite(). (Multisite routing is taken care of by WordPress, not by the webserver; WP's generated RewriteBase etc are incorrect in multisite.) I think that the fix here is to reintroduce the is_multisite() check.

Attachments (1)

39547.diff (1.4 KB) - added by boonebgorges 3 years ago.

Download all attachments as: .zip

Change History (2)

@boonebgorges
3 years ago

#1 @boonebgorges
3 years ago

  • Keywords has-patch added

See 39547.diff. Ping @swissspidy for another set of eyes.

Note: See TracTickets for help on using tickets.