WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 months ago

#39547 closed defect (bug) (fixed)

options-permalink.php throws incorrect "You should update..." notice on multisite

Reported by: boonebgorges Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version: 4.6
Component: Permalinks Keywords: has-patch needs-refresh
Focuses: administration, multisite Cc:

Description

Setup:

  1. Subdirectory multisite installation on Apache with mod_rewrite
  2. /.htaccess/ and / should *not* be writable by the webserver
  3. On a secondary site (NOT blog 1), Dashboard > Options > Permalinks, ensure that you have pretty permalinks enabled (not index.php, not default)
  4. Click Save Changes without making any modifications
  5. You should see a green notice "You should update your .htaccess file now"

Prior to #37380, saving existing settings would result in a success notice. However, #37380 just fixed a bug in the implementation of [37747], so I think the bug comes from #35936.

Prior to [37747], the "You should update..." family of notices was never shown when is_multisite(). (Multisite routing is taken care of by WordPress, not by the webserver; WP's generated RewriteBase etc are incorrect in multisite.) I think that the fix here is to reintroduce the is_multisite() check.

Attachments (1)

39547.diff (1.4 KB) - added by boonebgorges 4 years ago.

Download all attachments as: .zip

Change History (9)

@boonebgorges
4 years ago

#1 @boonebgorges
4 years ago

  • Keywords has-patch added

See 39547.diff. Ping @swissspidy for another set of eyes.

This ticket was mentioned in Slack in #core by noisysocks. View the logs.


3 months ago

#3 @noisysocks
3 months ago

  • Focuses multisite added
  • Keywords needs-refresh added

#4 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.6
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#6 @SergeyBiryukov
3 months ago

Found a related bug while looking into this: #50834.

#7 @SergeyBiryukov
3 months ago

In 48712:

Permalinks: Simplify the logic for displaying "You should update your .htaccess file now" message.

See #39547, #50834.

#8 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48713:

Permalinks: Don't show "You should update your .htaccess file now" message when saving permalink settings on Multisite.

Multisite routing is taken care of by WordPress, not by the web server.

Follow-up to [13706], [37747], [38066].

Props boonebgorges.
Fixes #39547.

Note: See TracTickets for help on using tickets.