Improve DocBlocks in class-automatic-upgrader-skin.php

[carl-alberto]

Missing DocBlock Description and wrong @param formatting in:
wp-admin/includes/class-automatic-upgrader-skin.php
public function feedback( $data )

[Soean]

Hey Carl,
thanks for the patch. As I looked into the Automatic_Upgrader_Skin class, I saw that the
$messages property as well as the methods get_upgrade_messages(), header() and footer() need doc improvements. They should also handled by this ticket.

[carl-alberto]

Another attempt to improve docblock

[carl-alberto]

Hi Soean,

Thanks for the advice. sent another diff file to include the DocBlock improvement of:
$messages
get_upgrade_messages()
header()
footer()

Thanks!

[Soean]

#39606 was marked as a duplicate.

[SergeyBiryukov]

Needs a refresh to include 39606.patch:ticket:39606​.

[carl-alberto]

Here's another attempt

[mitraval192]

Added Ticket #39606 patch for the @access

[Soean]

The other WP_Upgrader_Skin classes also have incomplete DocBlocks:

• WP_Upgrader_Skin
• Bulk_Plugin_Upgrader_Skin
• Bulk_Theme_Upgrader_Skin
• Bulk_Upgrader_Skin
• Language_Pack_Upgrader_Skin
• Plugin_Installer_Skin
• Plugin_Upgrader_Skin
• Theme_Installer_Skin
• Theme_Upgrader_Skin

[carl-alberto]

Hi @Soean,

Do we tackle all the patches thru this ticket or separate tickets per file that don't have proper DocBlocks?

Thanks!

[SergeyBiryukov]

Replying to carl-alberto:

Do we tackle all the patches thru this ticket or separate tickets per file that don't have proper DocBlocks?

Let's create a separate ticket per file.

[carl-alberto]

Alright @SergeyBiryukov thanks!

[sabernhardt]

The @access notations were removed in r41161, and r49596 includes several additions.

If a docblock for $messages adds value, 39593.4.diff​ polishes that from the previous patch.