Customizer: unable to remove title on navigation

[karmatosed]

I went into navigation and removed title, but despite saving it stayed.

[westonruter]

@karmatosed I believe this is expected. When a nav menu item's label is empty it inherits its title from the object it is related with, so here “Sample Page”. However, I am confused by your screenshot because I see there is no placeholder. Do you have a blank space in there by chance?

[karmatosed]

My screenshot refers to the 'Sample Page' navigation just so it's clear what I'm expecting gone. That's what is staying.

I do not have a blank space. Whilst I don't, if this could get caused by a blank space can we fix that - seems potentially a common thing for users to do.

Even if this is expected, I'd suggest maybe we should try and have something better for users?

[westonruter]

@karmatosed placeholder-title.png​ is what I see in Chrome (nevermind that “Edit Page” button added by Customize Posts).

[westonruter]

And trim-input-title.mov​ demonstrates 39600.0.diff​ to trim the whitespace from an entered title (since it gets stripped upon saving anyway), ensuring that the original title of the underlying post/page will be displayed in the controls header and also in the placeholder text upon blur.

[karmatosed]

I don't seem able to replicate the issue with the patch - which is awesome! It totally seems to solve at least the issue of whitespace. I'm still not convinced I did have in video but totally unable to replicate now so lets go with this as a fix :)

[westonruter]

This issue was introduced in 4.7.

[westonruter]

In 39994:

Customize: Trim whitespace from nav menu item titles so that the underlying object's original title appears as input placeholder and in the control's title.

Whitespace is trimmed from titles in PHP when saved in any case, so this aligns the client-side behavior with what happens on the server.

Amends [38618].
See #38015.
Fixes #39600.

[westonruter]

Re-opening for minor release.

[dd32]

In 40094:

Customize: Trim whitespace from nav menu item titles so that the underlying object's original title appears as input placeholder and in the control's title.

Whitespace is trimmed from titles in PHP when saved in any case, so this aligns the client-side behavior with what happens on the server.

Amends [38618].
Merges [39994] to the 4.7 branch.
See #38015.
Fixes #39600.