WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#39611 closed defect (bug) (fixed)

Change message string in `wp-signup.php`

Reported by: jignesh.nakrani Owned by: flixos90
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch commit
Focuses: multisite Cc:

Description

change the message string to Greetings Network Administrator! The network currently allows &#8220;%s&#8221; registrations. To change or disable registration go to your <a href="%s">Options page</a>. and the $i18n['blog'] string to site to match current naming conventions in in wp-signup.php file

Ref #39209

Attachments (2)

39611.patch (1.4 KB) - added by jignesh.nakrani 3 years ago.
text changes as per #39209
39611.2.patch (1.8 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (5)

@jignesh.nakrani
3 years ago

text changes as per #39209

#1 @flixos90
3 years ago

  • Component changed from Role/Capability to Networks and Sites
  • Focuses multisite added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.8
  • Owner set to flixos90
  • Status changed from new to reviewing
  • Type changed from enhancement to defect (bug)

Thanks for the patch @jignesh.nakrani!

#2 @SergeyBiryukov
3 years ago

  • Keywords commit added

The current string is not i18n-friendly, whe should split it into several strings. See 39611.2.patch.

#3 @flixos90
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 39929:

Multisite: Correct and improve i18n strings in wp-signup.php.

The strings addressing the network administrator in wp-signup.php were still using the old terminology of blogs and sites. Furthermore concatenation of the strings has been removed to make them i18n-friendly.

Props jignesh.nakrani, SergeyBiryukov.
Fixes #39611.

Note: See TracTickets for help on using tickets.