WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#39620 closed enhancement (wontfix)

Improve PHP coding standards in class-automatic-upgrader-skin.php

Reported by: carl-alberto's profile carl-alberto Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7.1
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

Improved this file to follow these rules in the PHP Coding Standards ( ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/ )

  • IF conditions should always use braces
  • ARRAYS should have comma on last item

Attachments (1)

39620.diff​ (1.5 KB) - added by carl-alberto 9 years ago.
First attempt to fix this issue

Download all attachments as: .zip

Change History (2)

@carl-alberto
9 years ago

First attempt to fix this issue

#1 @dd32
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hi @carl-alberto

Thanks for the patch, however I'm going to close this as a wontfix item.

WordPress discourages code refactoring, which includes for coding standards, for maintenance and review burdens. Most of the WordPress files do not meet our coding standards in some form or another. Standards cleanup such as this is often done and accepted when the code in question is being modified/updated with fixes or enhancements though.

See ​https://make.wordpress.org/core/handbook/contribute/code-refactoring/ for more of our reasoning for rationale.

Note: See TracTickets for help on using tickets.