Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#39621 closed enhancement (wontfix)

Twenty Seventeen: Add Slack SVG icon in social media menu

Reported by: carl-alberto's profile carl-alberto Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7.1
Component: Bundled Theme Keywords: has-patch
Focuses: template Cc:

Description

Please add Slack as an SVG icon in twentyseventeen social media menu.

Thanks

Attachments (2)

39621.diff (5.4 KB) - added by carl-alberto 8 years ago.
Here's my patch to add slack icon
39621.2.diff (3.4 KB) - added by carl-alberto 8 years ago.
Sorry, please disregard the first patch, this is the correct one

Download all attachments as: .zip

Change History (10)

@carl-alberto
8 years ago

Here's my patch to add slack icon

#1 @carl-alberto
8 years ago

  • Keywords has-patch added

@carl-alberto
8 years ago

Sorry, please disregard the first patch, this is the correct one

#2 @SergeyBiryukov
8 years ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Add Slack SVG icon in twentyseventeen social media menu to Twenty Seventeen: Add Slack SVG icon in social media menu

#3 @davidakennedy
8 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hey @carl-alberto – thanks for the request!

I'm curious what you'd link to for a Slack icon?

I'm mostly against adding other icons at this point, unless the network is very large, or there is a high demand. That said, I'm closing this as I don't see adding this unless there's more demand.

#4 @carl-alberto
8 years ago

Hi @davidakennedy

We'll be linking it to our local WP Community Slack from our local WP community site, it would be nice to have that icon though.

Thanks!

#5 @miss_jwo
7 years ago

Just came across this as I also need to add in Slack as a social media item for a project I'm doing. Wanted to +1 this it is more than just @carl-alberto who needs this but i understand this might be a subset of world-wide industry and probably woudl be better as a plugin extension.

#6 @netweb
7 years ago

A SVG Slack icon was added to dashicons a while ago:

https://github.com/WordPress/dashicons/commit/199c64751f51926bcb26e52a384331e5ef2326a9

It not publicly published on https://developer.wordpress.org/resource/dashicons/ though (There are numerous "reserved" dashicons not published similar to this)

This ticket was mentioned in Slack in #design-dashicons by netweb. View the logs.


7 years ago

#8 @miss_jwo
7 years ago

For anyone who needs to extend Twentyseventeen to include Slack icon in the social menu now, and found this thread using a search engine ( That's how i ended up here), I created a little plugin: https://github.com/missjwo/twentyseventeen-social-slack

It would be cool if there was a way to add in extra svg files to the original list and then they can run through all eth svg files - so people can just extend the SVGs used as they need. I couldn't really work it out, so this replaces the original svg with a file which includes the Slack icon.

Note: See TracTickets for help on using tickets.