Opened 8 years ago
Closed 7 weeks ago
#39623 closed enhancement (wontfix)
Twenty Seventeen: Consider removing custom header from internal pages if selected video header
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | needs-refresh has-patch 2nd-opinion |
Focuses: | Cc: |
Description
This came up as I first off didn't even notice I still had default custom header until went to that blog page on the front end.
It felt logical to me that the video header I had set would continue in the main site or at least I'd not still see the default header image.
Attachments (1)
Change History (6)
#1
@
7 years ago
This made sense to me as well after building a couple of websites with 2017 that might have the need to use the video everywhere.
39623.diff adds an extra option under the Theme Options
in Customizer to apply the video in all pages instead of only the front page. Some users might still want the video on the front page only that's why I made it as an extra option instead of forcing it.
It is working ( the video is applied everywhere ) but the CSS is missing as that part got me a bit confused, if someone wants to tackle the CSS changes required for this it would be awesome.
Also a question came up when I was doing this: on the internal pages there is an extra 'header' with the featured image. Should that stay as is? Or if the video is to be played everywhere we should also cancel the featured image header ? I'm asking because if you see a full screen video + the header featured image the scroll down to content would be long I imagine.
(Note: For my websites purposes I have added extra css with a not-so-proper-way to bypass the default styling and have the video applied properly + hidden the featured image completely if the video is applied. )
#4
@
2 months ago
- Keywords 2nd-opinion added
@karmatosed I think that changing the behavior of the header now this long after the release of the theme would be a breaking change.
In the Customizer there is a message that displays if you are viewing a page other than the home/frontpage. The message says: "This theme does not support video headers on this page".
Is that message not enough?
#5
@
7 weeks ago
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from new to closed
Looking back on this considering it is an 8 year ticket I tend to agree. Let's close this and move on to focus on other areas. Thank you everyone. When I originally created it the point was valid but the point about the time passing is very valid.
Option to apply video header in internal pages