Opened 10 years ago
Closed 10 years ago
#39627 closed defect (bug) (fixed)
Custom Logo: Use correct theme mod in _media_states()
| Reported by: | pbiron | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.8 |
| Component: | Media | Version: | 4.5 |
| Severity: | normal | Keywords: | good-first-bug has-patch |
| Cc: | Focuses: |
Description
in wp-admin/includes/template.php,
function _media_states ( $post ) {
...
if ( $post->ID == get_theme_mod( 'site_logo' ) ) {
$media_states[] = __( 'Logo' );
}
should be
function _media_states ( $post ) {
...
if ( $post->ID == get_theme_mod( 'custom_logo' ) ) {
$media_states[] = __( 'Logo' );
}
As a result, when the Theme Customizer is used to add a custom logo, the image added as the custom logo is not tag as such in the Media Library because the wrong theme mod $name is checked.
Attachments (1)
Change History (5)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Thanks for reporting this!
Introduced in #33755 / [36698]. Forgotten in [36837]